This is an archive of the discontinued LLVM Phabricator instance.

[git-llvm] Check if svn and git-svn have been installed.
ClosedPublic

Authored by ruiu on May 23 2017, 12:59 PM.

Details

Summary

The error messages that git-llvm script prints out when svn or
git-svn are missing is very cryptic. I spent a fair amount of time
to find what was wrong with my environment. It looks like many
newcomers also exprienced a hard time to submit their first patches
due to this error.

This patch adds more user-friendly error messages.

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu created this revision.May 23 2017, 12:59 PM
rnk added a subscriber: rnk.May 23 2017, 1:04 PM
rnk added inline comments.
llvm/utils/git-svn/git-llvm
136 ↗(On Diff #99978)

Maybe call it program_exists? exists suggests that it is checking for file existence.

319–320 ↗(On Diff #99978)

I don't think this script relies on git-svn, so this shouldn't be necessary.

ruiu updated this revision to Diff 99980.May 23 2017, 1:16 PM
  • Address review comments
rnk accepted this revision.May 23 2017, 2:43 PM

lgtm

This revision is now accepted and ready to land.May 23 2017, 2:43 PM
This revision was automatically updated to reflect the committed changes.