This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Switch to incomplete translation units
ClosedPublic

Authored by krasimir on May 19 2017, 2:58 AM.

Reviewers

bkramer
ilya-biryukov

Commits

Summary

This speeds up code completion. All the cool kids (ycmd) are doing it.

Build Status

Buildable 6576
Build 6576: arc lint + arc unit

This revision is now accepted and ready to land.May 19 2017, 3:05 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clangd/

2 lines

Show All 39 Lines	ASTUnit::RemappedFile RemappedSource(
FileName,		FileName,
llvm::MemoryBuffer::getMemBufferCopy(Contents, FileName).release());		llvm::MemoryBuffer::getMemBufferCopy(Contents, FileName).release());

auto ArgP = &*ArgStrs.begin();		auto ArgP = &*ArgStrs.begin();
Unit = std::unique_ptr<ASTUnit>(ASTUnit::LoadFromCommandLine(		Unit = std::unique_ptr<ASTUnit>(ASTUnit::LoadFromCommandLine(
ArgP, ArgP + ArgStrs.size(), PCHs, Diags, ResourceDir,		ArgP, ArgP + ArgStrs.size(), PCHs, Diags, ResourceDir,
/OnlyLocalDecls=/false, /CaptureDiagnostics=/true, RemappedSource,		/OnlyLocalDecls=/false, /CaptureDiagnostics=/true, RemappedSource,
/RemappedFilesKeepOriginalName=/true,		/RemappedFilesKeepOriginalName=/true,
/PrecompilePreambleAfterNParses=/1, /TUKind=/TU_Complete,		/PrecompilePreambleAfterNParses=/1, /TUKind=/TU_Prefix,
/CacheCodeCompletionResults=/true,		/CacheCodeCompletionResults=/true,
/IncludeBriefCommentsInCodeCompletion=/true,		/IncludeBriefCommentsInCodeCompletion=/true,
/AllowPCHWithCompilerErrors=/true));		/AllowPCHWithCompilerErrors=/true));
}		}

void ClangdUnit::reparse(StringRef Contents) {		void ClangdUnit::reparse(StringRef Contents) {
// Do a reparse if this wasn't the first parse.		// Do a reparse if this wasn't the first parse.
// FIXME: This might have the wrong working directory if it changed in the		// FIXME: This might have the wrong working directory if it changed in the
▲ Show 20 Lines • Show All 168 Lines • Show Last 20 Lines