llvm-build: Get rid of 'import *'

[wanders]

Summary

This allows pyflakes catching more errors in the script.

[silvas]

From a python coding cleanliness standpoint this looks like a no-brainer. Do we have maintainer of llvm-build that can give this a second eye?

[• ddunbar]

LGTM

[wanders]

Closed by commit rL207012 (authored by andersg).

llvm/trunk/utils/llvm-build/llvmbuild/componentinfo.py

 """
 Descriptor objects for entities that are part of the LLVM project.
 """
 
 from __future__ import absolute_import
 try:
     import configparser
 except:
     import ConfigParser as configparser
 import sys
 
-from llvmbuild.util import *
+from llvmbuild.util import fatal, warning
 
 class ParseError(Exception):
     pass
 
 class ComponentInfo(object):
     """
     Base class for component descriptions.
     """

llvm/trunk/utils/llvm-build/llvmbuild/main.py

 from __future__ import absolute_import
 import os
 import sys
 
 import llvmbuild.componentinfo as componentinfo
 import llvmbuild.configutil as configutil
 
-from llvmbuild.util import *
+from llvmbuild.util import fatal, note
 
 ###
 
 def cmake_quote_string(value):
     """
     cmake_quote_string(value) -> str
 
     Return a quoted form of the given value that is suitable for use in CMake