This is an archive of the discontinued LLVM Phabricator instance.

Fix r302231 to use logical or (||)
ClosedPublic

Authored by sabuasal on May 18 2017, 2:13 PM.

Reviewers

Commits

Summary

In r302231 we mistakenly use bitwise or (|) instead of logical
or (||). This patch fixes that.

Thanks for having noticed.

Do you have commit rights?

This revision is now accepted and ready to land.May 18 2017, 2:35 PM

No I don't. Do you mind committing on my behalf please?

This revision was automatically updated to reflect the committed changes.

Path

Size

polly/

trunk/

lib/

Analysis/

2 lines

Show First 20 Lines • Show All 793 Lines • ▼ Show 20 Lines	void MemoryAccess::computeBoundsOnAccessRelation(unsigned ElementSize) {
auto *BasePtrSCEV = SE->getPointerBase(PtrSCEV);		auto *BasePtrSCEV = SE->getPointerBase(PtrSCEV);
if (BasePtrSCEV && !isa<SCEVCouldNotCompute>(BasePtrSCEV))		if (BasePtrSCEV && !isa<SCEVCouldNotCompute>(BasePtrSCEV))
PtrSCEV = SE->getMinusSCEV(PtrSCEV, BasePtrSCEV);		PtrSCEV = SE->getMinusSCEV(PtrSCEV, BasePtrSCEV);

const ConstantRange &Range = SE->getSignedRange(PtrSCEV);		const ConstantRange &Range = SE->getSignedRange(PtrSCEV);
if (Range.isFullSet())		if (Range.isFullSet())
return;		return;

if (Range.isWrappedSet() \| Range.isSignWrappedSet())		if (Range.isWrappedSet() \|\| Range.isSignWrappedSet())
return;		return;

bool isWrapping = Range.isSignWrappedSet();		bool isWrapping = Range.isSignWrappedSet();

unsigned BW = Range.getBitWidth();		unsigned BW = Range.getBitWidth();
const auto One = APInt(BW, 1);		const auto One = APInt(BW, 1);
const auto LB = isWrapping ? Range.getLower() : Range.getSignedMin();		const auto LB = isWrapping ? Range.getLower() : Range.getSignedMin();
const auto UB = isWrapping ? (Range.getUpper() - One) : Range.getSignedMax();		const auto UB = isWrapping ? (Range.getUpper() - One) : Range.getSignedMax();
▲ Show 20 Lines • Show All 4,102 Lines • Show Last 20 Lines