Page MenuHomePhabricator

maxf (Maximilian Falkenstein)
User

Projects

User does not belong to any projects.

User Details

User Since
May 4 2017, 4:51 AM (128 w, 5 d)

Recent Activity

Oct 1 2017

maxf added inline comments to D35471: [Polly] [RFC] Calculate AST expression type.
Oct 1 2017, 3:22 PM
maxf updated the diff for D35471: [Polly] [RFC] Calculate AST expression type.

More cleanups. Also fixed a pathologic edge case...

Oct 1 2017, 3:20 PM

Jul 30 2017

maxf updated the diff for D35471: [Polly] [RFC] Calculate AST expression type.

Another round of fixes:

  • All unit tests pass now. The last remaining test was changed to reflect the newly generated preconditions
  • Types are now limited to 63 bits to leave space for the sign bit
  • Fixed preconditions meaning the exact opposite of what was intended
  • Generate preconditions and parts of polly-acc generated code (e.g. host <-> device memory transfer) using fixed 64 bits
  • More code cleanup
Jul 30 2017, 6:16 PM

Jul 25 2017

maxf updated the diff for D35471: [Polly] [RFC] Calculate AST expression type.

Another round of fixes:

  • Fix last miscompiles in polly unittests. This brings us down to two testcases where the generated IR changed (GPU test cases excluded).
  • Prepare PPCGCodeGen. It's still not working (memory accesses need to be handled), but move initialization of options on isl_ctx so that they are set early enough for this. Also fix the addditional RTC generated by PPCGCodeGen.
  • Small cleanups
Jul 25 2017, 6:54 AM

Jul 22 2017

maxf updated the diff for D35471: [Polly] [RFC] Calculate AST expression type.

Another round of cleanups:

Jul 22 2017, 6:27 AM
maxf resigned from D35404: Email Test 2.
Jul 22 2017, 6:15 AM

Jul 18 2017

maxf updated the diff for D35471: [Polly] [RFC] Calculate AST expression type.

First round of cleanups:

  • Down to four test cases that fail code generation
  • Adressed most comments
  • Added an option to isl to not print bounds on values that polly enables per default
Jul 18 2017, 3:26 PM

Jul 17 2017

maxf added a comment to D35471: [Polly] [RFC] Calculate AST expression type.

No, this is not supposed to only change isl inside of polly. Among the things that were noted when I originally wanted to upstream the code into isl is a lack of motivation for the interface, since at that time it was a big patch to isl only. After discussion with Sven, we agreed on changing the original interface (store information in AST (expression) nodes instead of directly inside expressions) but before cleaning up and preparing another round of patches and resubmitting it seems like a good idea to show the whole code in one place so that we can agree on what and how we'd like isl to provide.

Jul 17 2017, 4:38 PM
maxf planned changes to D35471: [Polly] [RFC] Calculate AST expression type.

Hello Tobias,

Jul 17 2017, 4:18 PM

Jul 16 2017

maxf added a comment to D35471: [Polly] [RFC] Calculate AST expression type.

Note: Modifications in codegen.c are only for debugging.

Jul 16 2017, 7:40 PM
maxf created D35471: [Polly] [RFC] Calculate AST expression type.
Jul 16 2017, 7:36 PM

Jul 9 2017

maxf added a comment to D34971: Remove freed InvalidDomains from InvalidDomainMap..

I looked into providing a testcase and it seems to be infeasible, because the only test cases I can reliably reproduce this on are

  • MultiSource/Applications/JM/lencod/lencod
  • MultiSource/Applications/SIBsim4/SIBsim4
  • MultiSource/Benchmarks/MallocBench/gs/gs
  • MultiSource/Benchmarks/MiBench/automotive-susan/automotive-susan
  • MultiSource/Benchmarks/Ptrdist/bc/bc
  • MultiSource/Benchmarks/mafft/pairlocalalign

when running with "-polly-process-unprofitable". Those are all big multi-source tests and bugpoint also seems unable to reduce them by much. This seems to be kind of logical since this is essentially a heap corruption which is detected because glibc notices the corrupted free list, therefore we're most likely to detect it only if we're finding lots of ScOPs and then only as a side-effect, so I'm not sure how I would create a test that's suitable for our regression test suite in this case. I mean, I can include one of the above, but they are about 250KB.
POLLY_TEST_USE_VG results in make check-polly complaining, but as far as I can see due to a different issue that I have yet to track down...

Jul 9 2017, 6:13 AM

Jul 3 2017

maxf retitled D34903: Bump isl to isl-0.18-768-g033b61ae from [NFC] Bump isl to isl-0.18-767-gdf8f57f9 to Bump isl to isl-0.18-768-g033b61ae.
Jul 3 2017, 7:08 PM
maxf added a comment to D34903: Bump isl to isl-0.18-768-g033b61ae.

Hi Tobias,

Jul 3 2017, 7:08 PM
maxf updated the diff for D34903: Bump isl to isl-0.18-768-g033b61ae.

Update isl to isl-0.18-768-g033b61ae which includes an additional regression fix.

Jul 3 2017, 7:04 PM
maxf created D34971: Remove freed InvalidDomains from InvalidDomainMap..
Jul 3 2017, 5:49 PM

Jul 1 2017

maxf retitled D34903: Bump isl to isl-0.18-768-g033b61ae from Bump isl to isl-0.18-767-gdf8f57f9 to [NFC] Bump isl to isl-0.18-767-gdf8f57f9.
Jul 1 2017, 5:58 AM

Jun 30 2017

maxf created D34903: Bump isl to isl-0.18-768-g033b61ae.
Jun 30 2017, 12:56 PM

May 18 2017

maxf added a comment to D32893: Fix handling of signWrappedSets in access relations.

Hi everyone,

May 18 2017, 2:20 AM · Restricted Project

May 5 2017

maxf created D32893: Fix handling of signWrappedSets in access relations.
May 5 2017, 1:32 AM · Restricted Project