Page MenuHomePhabricator

Possible typo in ProgrammersManual documentation
Needs RevisionPublic

Authored by singam-sanjay on May 18 2017, 11:53 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

singam-sanjay created this revision.May 18 2017, 11:53 AM
sanjoy requested changes to this revision.Jun 24 2017, 12:37 PM

I'm not sure that this is a typo -- the existing doc is probably talking about the shapes of the struct and array types.

This revision now requires changes to proceed.Jun 24 2017, 12:37 PM

The novice reader would associate shape with only two of the DerivedTypes: VectorType and ArrayType. How could a FunctionType or an IntegerType have a shape ?

I'm not sure that this is a typo -- the existing doc is probably talking about the shapes of the struct and array types.

Also, I didn't understand what was meant by a struct having a shape.

I raised this patch because I had misinterpreted it the first time I read it.

The novice reader would associate shape with only two of the DerivedTypes: VectorType and ArrayType. How could a FunctionType or an IntegerType have a shape ?

I'm not sure that this is a typo -- the existing doc is probably talking about the shapes of the struct and array types.

Also, I didn't understand what was meant by a struct having a shape.

I raised this patch because I had misinterpreted it the first time I read it.

I see. My problem was that "There exists exactly one instance of a given Type at any one time." sounds like a circular statement. How about "Types in LLVM are interned, and this means pointer equality is the same as type equality".

silvas resigned from this revision.Mar 25 2020, 6:34 PM