Page MenuHomePhabricator

[libcxx] [test] Remove workaround for C1XX conversion-to-nullptr bug
ClosedPublic

Authored by CaseyCarter on May 17 2017, 10:30 AM.

Details

Summary

VSO#391542 "Types can't be convertible to nullptr_t," which will be fixed in the next release of Visual C++.

Also put internal bug numbers on the workarounds in test_workarounds.h for ease of correlation.

Diff Detail

Repository
rL LLVM

Event Timeline

CaseyCarter created this revision.May 17 2017, 10:30 AM
STL_MSFT added inline comments.May 17 2017, 11:06 AM
test/support/test_workarounds.h
21 ↗(On Diff #99326)

Do you need to go update the tests that were using this?

Commit the change to the affected test code as well.

CaseyCarter marked an inline comment as done.May 17 2017, 12:21 PM
CaseyCarter added inline comments.
test/support/test_workarounds.h
21 ↗(On Diff #99326)

Yes, thanks, poisoned_hash_helper.hpp didn't make it into the commit.

EricWF accepted this revision.May 25 2017, 12:36 AM

LGTM.

This revision is now accepted and ready to land.May 25 2017, 12:36 AM

@CaseyCarter Changes like this are good for post-commit review (ie just commit it)

This revision was automatically updated to reflect the committed changes.
CaseyCarter marked an inline comment as done.