This is an archive of the discontinued LLVM Phabricator instance.

[GlobalISel][X86] G_ADD/G_SUB vector legalizer/selector support.
ClosedPublic

Authored by igorb on May 16 2017, 1:56 AM.

Event Timeline

igorb created this revision.May 16 2017, 1:56 AM
zvi added inline comments.May 16 2017, 2:01 AM
test/CodeGen/X86/GlobalISel/sub-vec.ll
1

What SSE2 and AVX2? Should this file be split to 128, 256 and 512?

igorb added inline comments.May 16 2017, 2:13 AM
test/CodeGen/X86/GlobalISel/sub-vec.ll
1

Hi,
I added select-subv*.mir tests to test instruction selection per ISA set .
I am planing to add RUN with SSE/AVX1/AVX2/ etc to this file after i implement necessary instruction selection ( G_MERGE / G_UNMERGE) and legalization for illegal operations.

guyblank accepted this revision.May 18 2017, 12:17 AM

LGTM

if you can, please add TODOs in the sub tests so it will be clear which tests should be added after you implement the legalization support

This revision is now accepted and ready to land.May 18 2017, 12:17 AM
igorb updated this revision to Diff 99416.May 18 2017, 4:18 AM
  • fix according to comments.
  • Updated test with -verify-machineinstrs
  • rebase

Thanks for the review!

This revision was automatically updated to reflect the committed changes.