Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 6461 Build 6461: arc lint + arc unit
Event Timeline
lib/Transforms/IPO/PartialInlining.cpp | ||
---|---|---|
576 | IMHO the code that uses the BFI should be moved into a separate function which accepts a BFI reference. On the "!GetBFI" path, you'd make_unique a BFI and pass it into a helper. Else, you'd pass in "&(*GetBFI)(*Caller)". (On an unrelated note, I find "&(*GetBFI)(*Caller)" pretty hard to read...) |
Comment Actions
The code will be simplified (with related code removed) once the new PM is the default, but I don't see harm to change this way. lgtm
IMHO the code that uses the BFI should be moved into a separate function which accepts a BFI reference. On the "!GetBFI" path, you'd make_unique a BFI and pass it into a helper. Else, you'd pass in "&(*GetBFI)(*Caller)".
(On an unrelated note, I find "&(*GetBFI)(*Caller)" pretty hard to read...)