This is an archive of the discontinued LLVM Phabricator instance.

Disable threads in a few tests
ClosedPublic

Authored by rafael on May 12 2017, 8:24 AM.

Details

Reviewers
ruiu
davide
Summary

Because of https://bugs.llvm.org/show_bug.cgi?id=32942 some tests take a long time to run. Right now running

./bin/llvm-lit --time-tests -sv ~/llvm/lld/test/ELF

takes 7.08s, the slowest tests being

2.77s: lld :: ELF/many-alloc-sections.s
6.15s: lld :: ELF/many-sections.s

with this patch the same command takes 2.37s and the slowest tests are

1.40s: lld :: ELF/many-alloc-sections.s
1.47s: lld :: ELF/many-sections.s

Diff Detail

Event Timeline

rafael created this revision.May 12 2017, 8:24 AM
davide accepted this revision.May 12 2017, 9:08 AM
davide added a subscriber: davide.

LGTM. Please add a comment explaining why we pass -no-threads for the future reader.
FWIW, I hit the same issue on my machine and I'm glad you fixed it :)

This revision is now accepted and ready to land.May 12 2017, 9:08 AM
ruiu edited edge metadata.May 12 2017, 11:04 AM

Did you know why that test takes that much time with threading?

grimar added a subscriber: grimar.May 15 2017, 1:35 AM
ruiu accepted this revision.May 15 2017, 10:41 AM

LGTM with a comment describing threads are disabled for this test because it's too slow otherwise.

davide closed this revision.May 15 2017, 4:07 PM