Page MenuHomePhabricator

[Polly][GPUJIT] Disabled gcc's -Wpedantic for use of dlsym
ClosedPublic

Authored by PhilippSchaad on May 9 2017, 10:28 AM.

Details

Summary

GCC's ISO C standard does not strictly define the bahavior of converting a void*
pointer to a function pointer, but dlsym's POSIX standard does. The retrieval of function pointers
through dlsym in this case generates an unnecessary amount of warnings for every API function
assignment, bloating the output. Removing GCC's -Wpedantic flag only for the retrieval and
assignment of said functions thus seems like a good idea, simplifying debugging of the GPUJIT
in the future. Agree?

Event Timeline

PhilippSchaad created this revision.May 9 2017, 10:28 AM
grosser accepted this revision.May 9 2017, 10:36 AM

LGTM.

This revision is now accepted and ready to land.May 9 2017, 10:36 AM

I forgot to add: @bollu, feel free to critically review this regarding better alternatives or to decide to commit it as it is.

bollu edited edge metadata.May 10 2017, 1:52 AM

Could you please add a reference to the standard either in the code or the commit message? I believe this is the official reference.

added reference

This revision was automatically updated to reflect the committed changes.