Page MenuHomePhabricator

Remove unused code related to CPlusPlusLanguage::FindEquivalentNames
ClosedPublic

Authored by scott.smith on Apr 25 2017, 1:01 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

scott.smith created this revision.Apr 25 2017, 1:01 PM

This was used at some point. I'd be happier deleting if if I understood the reason why it is no longer needed.

scott.smith edited reviewers, added: Restricted Project; removed: lldb-commits.Apr 25 2017, 4:27 PM

I looked into the history of this code once and my understanding is that Enrico added this code in https://github.com/llvm-mirror/lldb/commit/bad9753828b6e0e415e38094bb9627e41d57874c but it have never been used (at least in upstream). The original commit message also indicates this.

I looked into the history of this code once and my understanding is that Enrico added this code in https://github.com/llvm-mirror/lldb/commit/bad9753828b6e0e415e38094bb9627e41d57874c but it have never been used (at least in upstream). The original commit message also indicates this.

That was four years ago! So we have code that is unused, has no tests, and is not visible via a library (since this header is not in include/lldb/*). The code is also short enough that it can be rewritten if anyone wants it. Ok to delete?

I am fully support deleting it (and pretty much any unused code). If we need it in the future then we will still have it in the svn history.

zturner accepted this revision.Apr 26 2017, 9:24 AM
zturner added a subscriber: zturner.

Code is still present in history, if someone needs this again in the future they can do some git archaeology to dig it up.

This revision is now accepted and ready to land.Apr 26 2017, 9:24 AM
scott.smith added a comment.EditedApr 26 2017, 9:43 AM

Can someone please commit this for me? I don't have access. Thank you!

Can someone please commit this for me? I don't have access. Thank you!

Ping - please commit for me!

This revision was automatically updated to reflect the committed changes.