This is an archive of the discontinued LLVM Phabricator instance.

Add missing acquire_load to call_once overload.
ClosedPublic

Authored by jlebar on Apr 23 2017, 10:02 AM.

Reviewers

Commits

Summary

Seemed to have been overlooked in D24028.

This bug was found and brought to my attention by Paul Wankadia.

jlebar edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Apr 23 2017, 10:06 AM

Thank you for the review, Dmitry.

This revision was automatically updated to reflect the committed changes.

Thanks for catching this!

Path

Size

libcxx/

trunk/

include/

2 lines

Show First 20 Lines • Show All 679 Lines • ▼ Show 20 Lines	call_once(once_flag& __flag, _Callable& __func)
}		}
}		}

template<class _Callable>		template<class _Callable>
inline _LIBCPP_INLINE_VISIBILITY		inline _LIBCPP_INLINE_VISIBILITY
void		void
call_once(once_flag& __flag, const _Callable& __func)		call_once(once_flag& __flag, const _Callable& __func)
{		{
if (__flag.__state_ != ~0ul)		if (__libcpp_acquire_load(&__flag.__state_) != ~0ul)
{		{
__call_once_param<const _Callable> __p(__func);		__call_once_param<const _Callable> __p(__func);
__call_once(__flag.__state_, &__p, &__call_once_proxy<const _Callable>);		__call_once(__flag.__state_, &__p, &__call_once_proxy<const _Callable>);
}		}
}		}

#endif // _LIBCPP_CXX03_LANG		#endif // _LIBCPP_CXX03_LANG

_LIBCPP_END_NAMESPACE_STD		_LIBCPP_END_NAMESPACE_STD

#endif // _LIBCPP_MUTEX		#endif // _LIBCPP_MUTEX