This is an archive of the discontinued LLVM Phabricator instance.

Don't use abort_on_error for lsan darwin test suite
ClosedPublic

Authored by fjricci on Apr 17 2017, 10:52 AM.

Details

Summary

This option is disabled by our other test suites, and will cause
failures when unit tests abort instead of failing with an error code.
Will also prevent the test suite from being too slow.

Event Timeline

fjricci created this revision.Apr 17 2017, 10:52 AM
kubamracek edited edge metadata.Apr 17 2017, 11:12 AM

Can this be two separate changes, 1) NFC for the LSAN_OPTIONS => %env_lsan_opts conversion, and 2) the Darwin change to add abort_on_error=0?

fjricci planned changes to this revision.Apr 17 2017, 11:15 AM

Yeah, I can do that.

fjricci updated this revision to Diff 95463.Apr 17 2017, 11:21 AM

Split out abort_on_error and NFC

kubamracek accepted this revision.Apr 17 2017, 11:31 AM
This revision is now accepted and ready to land.Apr 17 2017, 11:31 AM
This revision was automatically updated to reflect the committed changes.