Fuchsia's libc was forked from musl, but has evolved sufficiently since then so it no longer makes sense to pretend it's musl. This change implements direct support for Fuchsia rather than piggybacking on musl support.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM minus inline comments.
include/__locale | ||
---|---|---|
44 | This #endif comment is no longer correct. Please remove it as part of this change. | |
include/support/fuchsia/xlocale.h | ||
14 | I don't see the need for this guard, since the header should never be included outside of a Fuchsia environment. #if !defined(__Fuchsia__) #error Fuchsia specific header incorrectly included #endif |
include/support/fuchsia/xlocale.h | ||
---|---|---|
14 | I was following the pattern used by Android and Newlib, but I'm happy to remove this if you prefer? |
This #endif comment is no longer correct. Please remove it as part of this change.