This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Direct support for Fuchsia
ClosedPublic

Authored by phosek on Apr 11 2017, 8:50 PM.

Details

Summary

Fuchsia's libc was forked from musl, but has evolved sufficiently since then so it no longer makes sense to pretend it's musl. This change implements direct support for Fuchsia rather than piggybacking on musl support.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Apr 11 2017, 8:50 PM
phosek updated this revision to Diff 95026.Apr 12 2017, 1:54 PM
EricWF accepted this revision.Apr 12 2017, 2:23 PM

LGTM minus inline comments.

include/__locale
44

This #endif comment is no longer correct. Please remove it as part of this change.

include/support/fuchsia/xlocale.h
14

I don't see the need for this guard, since the header should never be included outside of a Fuchsia environment.
If anything it should read:

#if !defined(__Fuchsia__)
#error Fuchsia specific header incorrectly included
#endif
This revision is now accepted and ready to land.Apr 12 2017, 2:23 PM
phosek updated this revision to Diff 95076.Apr 12 2017, 7:42 PM
phosek marked an inline comment as done.
phosek added inline comments.Apr 12 2017, 8:29 PM
include/support/fuchsia/xlocale.h
14

I was following the pattern used by Android and Newlib, but I'm happy to remove this if you prefer?

This revision was automatically updated to reflect the committed changes.