This is an archive of the discontinued LLVM Phabricator instance.

Mark a test as requiring a shell
ClosedPublic

Authored by rafael on Apr 6 2017, 1:26 PM.

Details

Reviewers
filcab
rnk
Summary

These two have hard to replace uses of sub shells.

Diff Detail

Event Timeline

rafael created this revision.Apr 6 2017, 1:26 PM
rnk added inline comments.Apr 6 2017, 4:03 PM
compiler-rt/test/asan/TestCases/Linux/read_binary_name_regtest.c
5–6

I feel like a more LLVM-y way to do this would be to feature test seccomp in cmake and use REQUIRES: seccomp or something, but it's totally not worth it for one test.

compiler-rt/test/asan/TestCases/Linux/swapcontext_annotation.cc
7 ↗(On Diff #94430)

I think we can just replace this with a temporary file:

// RUN: seq 60 | xargs -i -- grep LOOPCHECK %s > %t.checks
// RUN: %clangxx_asan ... | FileCheck %t.checks --check-prefix=LOOPCHECK
// RUN: %clangxx_asan ... | FileCheck %t.checks --check-prefix=LOOPCHECK
// RUN: %clangxx_asan ... | FileCheck %t.checks --check-prefix=LOOPCHECK

That's more or less what <() is doing.

rafael updated this revision to Diff 94554.Apr 7 2017, 12:12 PM
rafael retitled this revision from Mark two tests as requiring a shell to Mark a test as requiring a shell.
rnk accepted this revision.Apr 10 2017, 12:01 PM

lgtm

This revision is now accepted and ready to land.Apr 10 2017, 12:01 PM