Simplify test a bit

[• rafael]

Summary

There are two cases to consider:

We are using the internal shell. This will still fail because of ulimit.
We are using an external shell. In this case the difference is that we now also constrain FileCheck to use less than 4 MB of of stack, which it should :-)

[rnk]

I thought ulimit was a bash builtin that affects the limits of the shell process. Even if ulimit exists as a separate command, I don't think shelling out to it will affect the parent process. Maybe this is a good place to run bash -c?

[filcab]

I think Rafael's reasoning makes sense and am ok with this.
In the internal shell it wasn't working, so there's no change there. In the external shell, the change looks benign.
I don't expect FileCheck, even compiled with -O0, to have a problem with a 4MiB stack.

[rnk]

lgtm

Sure, this is simpler, and I'm not concerned about FileCheck blowing out a 4MB stack.

Do you want to add REQUIRES: shell in this change as well, since this test probably still fails with "ulimit: command not found" when setting LIT_USE_INTERNAL_SHELL=1?

compiler-rt/test/asan/TestCases/Posix/deep_call_stack.cc

 // Check that UAR mode can handle very deep recusrion.
-// RUN: %clangxx_asan -O2 %s -o %t && \
-// RUN:   (ulimit -s 4096; %env_asan_opts=detect_stack_use_after_return=1 %run %t) 2>&1 | FileCheck %s
+// RUN: %clangxx_asan -O2 %s -o %t
+// RUN: ulimit -s 4096
+// RUN: %env_asan_opts=detect_stack_use_after_return=1 %run %t 2>&1 | FileCheck %s
 
 // Also check that use_sigaltstack+verbosity doesn't crash.
 // RUN: %env_asan_opts=verbosity=1:use_sigaltstack=1:detect_stack_use_after_return=1 %run %t  | FileCheck %s