Page MenuHomePhabricator

Prefer non-friend to friend in in redeclaration chain
ClosedPublic

Authored by yaron.keren on Mar 31 2017, 9:12 AM.

Details

Summary

Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse. This also fixes two FIXME in SemaTemplate/friend-template.cpp.

Diff Detail

Event Timeline

yaron.keren created this revision.Mar 31 2017, 9:12 AM

Could you also add the testcase where the friend declaration has some attributes?

Thanks, I'll make a test.

Added attribute test.

This revision was automatically updated to reflect the committed changes.
yaron.keren reopened this revision.Apr 17 2017, 11:42 PM

reverted in r300497

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Oct 7, 6:15 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Oct 7, 6:15 AM