This is an archive of the discontinued LLVM Phabricator instance.

Differential D31436

[yaml2obj] Enable and fix tests
ClosedPublic

Authored by sbc100 on Mar 28 2017, 1:36 PM.

Details

Reviewers
beanz
Commits
rG460b54ef6dfd: [yaml2obj] Enable and fix tests
rL299088: [yaml2obj] Enable and fix tests
Summary

These tests were not being run because the yaml extension
wasn't be picked up by lit.

This change also fixes the tests which themselves were broken.

Diff Detail

Event Timeline

sbc100 created this revision.Mar 28 2017, 1:36 PM
Herald added a subscriber: fhahn. · View Herald TranscriptMar 28 2017, 1:36 PM
sbc100 retitled this revision from Enable yaml2obj tests to [yaml2obj] Enable and fix tests.Mar 28 2017, 1:36 PM
sbc100 added a reviewer: beanz.
beanz accepted this revision.Mar 28 2017, 3:18 PM

LGTM!

Thanks for catching this. I didn't even notice that I had written such bad tests!

This revision is now accepted and ready to land.Mar 28 2017, 3:18 PM
sbc100 edited the summary of this revision. (Show Details)Mar 28 2017, 4:00 PM

Would you mind committing this (I'm not yet a committer).

sbc100 mentioned this in D31351: [yaml2obj] Improve error message when output file cannot be opened.Mar 28 2017, 4:16 PM
Closed by commit rL299088: [yaml2obj] Enable and fix tests (authored by cbieneman). · Explain WhyMar 30 2017, 9:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
tools/
yaml2obj/
1 line
3 lines
2 lines

Diff 93291

test/tools/yaml2obj/lit.local.cfg

  • This file was added.
config.suffixes = ['.yaml']

test/tools/yaml2obj/missing_document_tag.yaml

# RUN: not yaml2obj %s 2>&1 | FileCheck %s # RUN: not yaml2obj %s 2>&1 | FileCheck %s
--- ---
DummyData: DummyData:
foo: 0 foo: 0
... ...
# CHECK: YAML:4:1: error: YAML Object File missing document type tag!
# CHECK: yaml2obj: Failed to parse YAML file!

test/tools/yaml2obj/unsupported_document_tag.yaml

# RUN: not yaml2obj %s 2>&1 | FileCheck %s # RUN: not yaml2obj %s 2>&1 | FileCheck %s
--- !unsupported-tag --- !unsupported-tag
DummyData: DummyData:
foo: 0 foo: 0
... ...
#check error: YAML Object File unsupported document type tag '!unsupported-tag'! # CHECK: error: YAML Object File unsupported document type tag '!unsupported-tag'!