This is an archive of the discontinued LLVM Phabricator instance.

[NFC, Refactor] Modernize TemplateIdAnnotation using TrailingObjects
ClosedPublic

Authored by faisalv on Mar 27 2017, 8:31 PM.

Details

Summary

Refactor TemplateIdAnnotation to use TrailingObjects and add assorted comments.

Diff Detail

Event Timeline

faisalv created this revision.Mar 27 2017, 8:31 PM
faisalv updated this revision to Diff 93207.Mar 27 2017, 8:53 PM

Don't forget to destroy the trailing objects.

aaron.ballman added inline comments.May 22 2017, 7:10 AM
include/clang/Sema/ParsedTemplate.h
202

Spurious semi colon?

215

Why is this returning the result of an explicit destructor call?

Also a should be named A per usual naming conventions.

faisalv updated this revision to Diff 99787.May 22 2017, 10:52 AM

Incorporated Aaron's feedback - thanks Aaron!

faisalv marked 2 inline comments as done.May 22 2017, 10:53 AM

mark aaron's feedback as done.

This revision is now accepted and ready to land.May 22 2017, 11:08 AM