This is an archive of the discontinued LLVM Phabricator instance.

Add more examples to clang-format configuration
ClosedPublic

Authored by sylvestre.ledru on Mar 27 2017, 4:01 PM.

Diff Detail

Event Timeline

Eugene.Zelenko added inline comments.
docs/ClangFormatStyleOptions.rst
644

Shouldn't it be java?

1293

Shouldn't it be objective-c?

Thanks, indeed! :)

sylvestre.ledru marked 2 inline comments as done.Mar 27 2017, 4:44 PM
djasper edited edge metadata.Mar 30 2017, 11:47 PM

Generally please upload diffs with more contexts. For some here it's not even clear to which option they refer ;)

docs/ClangFormatStyleOptions.rst
941

You could force line wraps with tailing //-comments instead.

978

I think this example is very confusing. Possibly for this option, it doesn't really makes sense to give examples. Or don't have a before/after but instead have two examples where clang-format determines different pointer alignment?

sylvestre.ledru added inline comments.
docs/ClangFormatStyleOptions.rst
941

much better. thanks

978

right, removed.
I updated the wording of the desc

Daniel, is that ok with you?

djasper accepted this revision.Apr 10 2017, 11:12 PM

Yes, thank you!

This revision is now accepted and ready to land.Apr 10 2017, 11:12 PM