This is an archive of the discontinued LLVM Phabricator instance.

PluginUnwindAssemblyX86: add missing linkage to MCDisasm
ClosedPublic

Authored by mgorny on Mar 25 2017, 7:02 AM.

Details

Summary

Add missing linkage of the lldbPluginUnwindAssemblyX86 to LLVMMCDisasm
library. This fixes the following build failure when linking against
shared libraries:

lib64/liblldbPluginUnwindAssemblyX86.a(x86AssemblyInspectionEngine.cpp.o):x86AssemblyInspectionEngine.cpp:function lldb_private::x86AssemblyInspectionEngine::instruction_length(unsigned char*, int&): error: undefined reference to 'LLVMDisasmInstruction'
lib64/liblldbPluginUnwindAssemblyX86.a(x86AssemblyInspectionEngine.cpp.o):x86AssemblyInspectionEngine.cpp:function lldb_private::x86AssemblyInspectionEngine::~x86AssemblyInspectionEngine(): error: undefined reference to 'LLVMDisasmDispose'
lib64/liblldbPluginUnwindAssemblyX86.a(x86AssemblyInspectionEngine.cpp.o):x86AssemblyInspectionEngine.cpp:function lldb_private::x86AssemblyInspectionEngine::x86AssemblyInspectionEngine(lldb_private::ArchSpec const&): error: undefined reference to 'LLVMCreateDisasm'

Diff Detail

Event Timeline

mgorny created this revision.Mar 25 2017, 7:02 AM
joerg accepted this revision.Mar 25 2017, 11:53 AM
This revision is now accepted and ready to land.Mar 25 2017, 11:53 AM
This revision was automatically updated to reflect the committed changes.