This is an archive of the discontinued LLVM Phabricator instance.

Differential D31256

Verifier: Check some amdgpu calling convention restrictions
ClosedPublic

Authored by arsenm on Mar 22 2017, 1:02 PM.

Download Raw Diff

Details

Reviewers

t-tye

Diff Detail

Event Timeline

arsenm created this revision.Mar 22 2017, 1:02 PM

Herald added subscribers: tpr, dstuttard, tony-tye and 4 others. · View Herald TranscriptMar 22 2017, 1:02 PM

Allow shader return types

t-tye added a subscriber: t-tye.Mar 22 2017, 6:41 PM

tony-tye removed a subscriber: tony-tye.Mar 22 2017, 6:48 PM

ping

LGTM

lib/IR/Verifier.cpp
2021	Blank line.

This revision is now accepted and ready to land.Apr 4 2017, 11:18 AM

r299457

Revision Contents

Path

Size

lib/

IR/

Verifier.cpp

14 lines

test/

Verifier/

amdgpu-cc.ll

55 lines

Diff 92697

lib/IR/Verifier.cpp

Show First 20 Lines • Show All 2,000 Lines • ▼ Show 20 Lines	void Verifier::visitFunction(const Function &F) {

// Check that this function meets the restrictions on this calling convention.		// Check that this function meets the restrictions on this calling convention.
// Sometimes varargs is used for perfectly forwarding thunks, so some of these		// Sometimes varargs is used for perfectly forwarding thunks, so some of these
// restrictions can be lifted.		// restrictions can be lifted.
switch (F.getCallingConv()) {		switch (F.getCallingConv()) {
default:		default:
case CallingConv::C:		case CallingConv::C:
break;		break;
		case CallingConv::AMDGPU_KERNEL:
		case CallingConv::SPIR_KERNEL:
		Assert(F.getReturnType()->isVoidTy(),
		"Calling convention requires void return type", &F);
		LLVM_FALLTHROUGH;

		case CallingConv::AMDGPU_VS:
		case CallingConv::AMDGPU_GS:
		case CallingConv::AMDGPU_PS:
		case CallingConv::AMDGPU_CS:
		Assert(!F.hasStructRetAttr(),
		"Calling convention does not allow sret", &F);

		t-tyeUnsubmitted Not Done Reply Inline Actions Blank line. t-tye: Blank line.
		LLVM_FALLTHROUGH;
case CallingConv::Fast:		case CallingConv::Fast:
case CallingConv::Cold:		case CallingConv::Cold:
case CallingConv::Intel_OCL_BI:		case CallingConv::Intel_OCL_BI:
case CallingConv::PTX_Kernel:		case CallingConv::PTX_Kernel:
case CallingConv::PTX_Device:		case CallingConv::PTX_Device:
Assert(!F.isVarArg(), "Calling convention does not support varargs or "		Assert(!F.isVarArg(), "Calling convention does not support varargs or "
"perfect forwarding!",		"perfect forwarding!",
&F);		&F);
▲ Show 20 Lines • Show All 2,890 Lines • Show Last 20 Lines

test/Verifier/amdgpu-cc.ll

This file was added.

				; RUN: not llvm-as < %s 2>&1 \| FileCheck %s

				; CHECK: Calling convention requires void return type
				; CHECK-NEXT: i32 ()* @nonvoid_cc_amdgpu_kernel
				define amdgpu_kernel i32 @nonvoid_cc_amdgpu_kernel() {
				ret i32 0
				}

				; CHECK: Calling convention does not support varargs or perfect forwarding!
				; CHECK-NEXT: void (...)* @varargs_amdgpu_kernel
				define amdgpu_kernel void @varargs_amdgpu_kernel(...) {
				ret void
				}

				; CHECK: Calling convention does not allow sret
				; CHECK-NEXT: void (i32) @sret_cc_amdgpu_kernel
				define amdgpu_kernel void @sret_cc_amdgpu_kernel(i32* sret %ptr) {
				ret void
				}

				; CHECK: Calling convention does not support varargs or perfect forwarding!
				; CHECK-NEXT: void (...)* @varargs_amdgpu_vs
				define amdgpu_vs void @varargs_amdgpu_vs(...) {
				ret void
				}

				; CHECK: Calling convention does not support varargs or perfect forwarding!
				; CHECK-NEXT: void (...)* @varargs_amdgpu_gs
				define amdgpu_gs void @varargs_amdgpu_gs(...) {
				ret void
				}

				; CHECK: Calling convention does not support varargs or perfect forwarding!
				; CHECK-NEXT: void (...)* @varargs_amdgpu_ps
				define amdgpu_ps void @varargs_amdgpu_ps(...) {
				ret void
				}

				; CHECK: Calling convention does not support varargs or perfect forwarding!
				; CHECK-NEXT: void (...)* @varargs_amdgpu_cs
				define amdgpu_cs void @varargs_amdgpu_cs(...) {
				ret void
				}

				; CHECK: Calling convention requires void return type
				; CHECK-NEXT: i32 ()* @nonvoid_cc_spir_kernel
				define spir_kernel i32 @nonvoid_cc_spir_kernel() {
				ret i32 0
				}

				; CHECK: Calling convention does not support varargs or perfect forwarding!
				; CHECK-NEXT: void (...)* @varargs_spir_kernel
				define spir_kernel void @varargs_spir_kernel(...) {
				ret void
				}