The idea is that the policy string fully specifies the policy and is portable
between clients.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Neat! LGTM.
llvm/include/llvm/LTO/Caching.h | ||
---|---|---|
23 ↗ | (On Diff #91968) | Do all the clients of this header need this declaration? I found strange that nothing changes in the header but this is needed. |
llvm/include/llvm/Support/CachePruning.h | ||
47 ↗ | (On Diff #91968) | Could you add an example syntax here? |
llvm/lib/Support/CachePruning.cpp | ||
37 ↗ | (On Diff #91968) | Why "Interval"? It seems that you're parsing a "time" or a "duration"? |
98 ↗ | (On Diff #91968) | StringSwitch? I guess it does not play well with the error to return... |
llvm/include/llvm/LTO/Caching.h | ||
---|---|---|
23 ↗ | (On Diff #91968) | This was an unintentional change, I've reverted it. |
llvm/lib/Support/CachePruning.cpp | ||
37 ↗ | (On Diff #91968) | They're synonyms for the most part, but it looks like "duration" is the term used by the stdlib and distinguishes from the pruning interval, so I've switched to it. |
98 ↗ | (On Diff #91968) | Right, I guess I'd have to go through contortions in this code that would outweigh the value of StringSwitch IMHO. |
llvm/lib/Support/CachePruning.cpp | ||
---|---|---|
37 ↗ | (On Diff #91968) | OK. |