This is an archive of the discontinued LLVM Phabricator instance.

Differential D30958

[CMake] Support building Fuchsia toolchain on Darwin
ClosedPublic

Authored by phosek on Mar 14 2017, 3:33 PM.

Details

Reviewers
beanz
Commits
rG60f54ac8c5d4: [CMake] Support building Fuchsia toolchain on Darwin
rC300257: [CMake] Support building Fuchsia toolchain on Darwin
rL300257: [CMake] Support building Fuchsia toolchain on Darwin
Summary

This is already supported on Linux but on Darwin it requires some extra flags.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Mar 14 2017, 3:33 PM
Herald added a subscriber: mgorny. · View Herald TranscriptMar 14 2017, 3:33 PM
phosek added inline comments.Mar 14 2017, 3:38 PM
cmake/caches/Fuchsia.cmake
3

This is only needed because the first stage compiler is building host builtins which on Darwin require extra architecture support. I don't know if there is a way to disable this behavior? One option I can think of would be to set LLVM_BUILTIN_TARGETS to "". Alternative would be to add a new CMake option, e.g. LLVM_INCLUDE_RUNTIMES.

phosek added inline comments.Mar 16 2017, 3:17 PM
cmake/caches/Fuchsia.cmake
3

I've implemented that option in D31060.

phosek marked 2 inline comments as done.Mar 17 2017, 3:13 PM
phosek added inline comments.
cmake/caches/Fuchsia.cmake
3

Turned out this is not going to work since the runtimes build is apparently needed by the second stage compiler.

phosek mentioned this in D30957: [CMake] Support single target builtins build on Darwin.Mar 21 2017, 3:47 PM
beanz added inline comments.Mar 21 2017, 3:56 PM
cmake/caches/Fuchsia.cmake
3

You can disable the embedded builtins by turning off COMPILER_RT_ENABLE_IOS. There are corresponding WATCHOS and TVOS options that you might want to hit off as well. They default off, but defaults do change sometimes.

phosek updated this revision to Diff 92591.Mar 21 2017, 8:26 PM
phosek marked 3 inline comments as done.

Thanks, this is exactly what I was looking for!

beanz accepted this revision.Mar 22 2017, 1:29 PM

Looks great!

This revision is now accepted and ready to land.Mar 22 2017, 1:29 PM
Closed by commit rL300257: [CMake] Support building Fuchsia toolchain on Darwin (authored by phosek). · Explain WhyApr 13 2017, 2:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
caches/
4 lines
4 lines

Diff 91785

cmake/caches/Fuchsia-stage2.cmake

Show All 13 Lines
set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "") set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "")
set(LLVM_ENABLE_LTO ON CACHE BOOL "") set(LLVM_ENABLE_LTO ON CACHE BOOL "")
if(NOT APPLE) if(NOT APPLE)
set(LLVM_ENABLE_LLD ON CACHE BOOL "") set(LLVM_ENABLE_LLD ON CACHE BOOL "")
set(CLANG_DEFAULT_LINKER lld CACHE STRING "") set(CLANG_DEFAULT_LINKER lld CACHE STRING "")
endif() endif()
if(APPLE)
set(LLDB_CODESIGN_IDENTITY "" CACHE STRING "")
endif()
set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "") set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O2 -gline-tables-only -DNDEBUG" CACHE STRING "") set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O2 -gline-tables-only -DNDEBUG" CACHE STRING "")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -gline-tables-only -DNDEBUG" CACHE STRING "") set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -gline-tables-only -DNDEBUG" CACHE STRING "")
set(LLVM_BUILTIN_TARGETS "x86_64-fuchsia-none;aarch64-fuchsia-none" CACHE STRING "") set(LLVM_BUILTIN_TARGETS "x86_64-fuchsia-none;aarch64-fuchsia-none" CACHE STRING "")
set(BUILTINS_x86_64-fuchsia-none_CMAKE_SYSROOT ${FUCHSIA_SYSROOT} CACHE STRING "") set(BUILTINS_x86_64-fuchsia-none_CMAKE_SYSROOT ${FUCHSIA_SYSROOT} CACHE STRING "")
set(BUILTINS_x86_64-fuchsia-none_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "") set(BUILTINS_x86_64-fuchsia-none_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "")
set(BUILTINS_aarch64-fuchsia-none_CMAKE_SYSROOT ${FUCHSIA_SYSROOT} CACHE STRING "") set(BUILTINS_aarch64-fuchsia-none_CMAKE_SYSROOT ${FUCHSIA_SYSROOT} CACHE STRING "")
Show All 33 Lines

cmake/caches/Fuchsia.cmake

# This file sets up a CMakeCache for a Fuchsia toolchain build. # This file sets up a CMakeCache for a Fuchsia toolchain build.
if(NOT APPLE)
phosekAuthorUnsubmitted
Done
ReplyInline Actions

This is only needed because the first stage compiler is building host builtins which on Darwin require extra architecture support. I don't know if there is a way to disable this behavior? One option I can think of would be to set LLVM_BUILTIN_TARGETS to "". Alternative would be to add a new CMake option, e.g. LLVM_INCLUDE_RUNTIMES.

phosek: This is only needed because the first stage compiler is building host builtins which on Darwin…
phosekAuthorUnsubmitted
Done
ReplyInline Actions

I've implemented that option in D31060.

phosek: I've implemented that option in D31060.
phosekAuthorUnsubmitted
Done
ReplyInline Actions

Turned out this is not going to work since the runtimes build is apparently needed by the second stage compiler.

phosek: Turned out this is not going to work since the runtimes build is apparently needed by the…
beanzUnsubmitted
Done
ReplyInline Actions

You can disable the embedded builtins by turning off COMPILER_RT_ENABLE_IOS. There are corresponding WATCHOS and TVOS options that you might want to hit off as well. They default off, but defaults do change sometimes.

beanz: You can disable the embedded builtins by turning off `COMPILER_RT_ENABLE_IOS`. There are…
set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "") set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "")
endif()
set(PACKAGE_VENDOR Fuchsia CACHE STRING "") set(PACKAGE_VENDOR Fuchsia CACHE STRING "")
set(LLVM_INCLUDE_EXAMPLES OFF CACHE BOOL "") set(LLVM_INCLUDE_EXAMPLES OFF CACHE BOOL "")
set(LLVM_INCLUDE_TESTS OFF CACHE BOOL "") set(LLVM_INCLUDE_TESTS OFF CACHE BOOL "")
set(LLVM_INCLUDE_DOCS OFF CACHE BOOL "") set(LLVM_INCLUDE_DOCS OFF CACHE BOOL "")
set(CLANG_INCLUDE_TESTS OFF CACHE BOOL "") set(CLANG_INCLUDE_TESTS OFF CACHE BOOL "")
set(LLVM_ENABLE_ZLIB OFF CACHE BOOL "") set(LLVM_ENABLE_ZLIB OFF CACHE BOOL "")
Show All 33 Lines