This is an archive of the discontinued LLVM Phabricator instance.

Differential D30947

[Driver] Fix arch-specific-libdir-rpath.c
ClosedPublic

Authored by pirama on Mar 14 2017, 10:36 AM.

Details

Reviewers
srhines
rnk
Commits
rGcd037451d762: [Driver] Fix arch-specific-libdir-rpath.c
rC297754: [Driver] Fix arch-specific-libdir-rpath.c
rL297754: [Driver] Fix arch-specific-libdir-rpath.c
Summary

Fix the test by adding missing -target flags with a 'linux' triple.

Diff Detail

Event Timeline

pirama created this revision.Mar 14 2017, 10:36 AM
rnk accepted this revision.Mar 14 2017, 10:38 AM

lgtm

This revision is now accepted and ready to land.Mar 14 2017, 10:38 AM
Closed by commit rL297754: [Driver] Fix arch-specific-libdir-rpath.c (authored by pirama). · Explain WhyMar 14 2017, 10:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
Driver/
6 lines

Diff 91746

test/Driver/arch-specific-libdir-rpath.c

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
// //
// Add LIBPATH, RPATH for OpenMP // Add LIBPATH, RPATH for OpenMP
// RUN: %clang %s -### 2>&1 -target x86_64-linux -fopenmp \ // RUN: %clang %s -### 2>&1 -target x86_64-linux -fopenmp \
// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \ // RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
// RUN: -frtlib-add-rpath \ // RUN: -frtlib-add-rpath \
// RUN: | FileCheck --check-prefixes=RESDIR,LIBPATH-X86_64,RPATH-X86_64 %s // RUN: | FileCheck --check-prefixes=RESDIR,LIBPATH-X86_64,RPATH-X86_64 %s
// //
// Add LIBPATH but no RPATH for ubsan (or any other sanitizer) // Add LIBPATH but no RPATH for ubsan (or any other sanitizer)
// RUN: %clang %s -### 2>&1 -fsanitize=undefined \ // RUN: %clang %s -### 2>&1 -fsanitize=undefined -target x86_64-linux \
// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \ // RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
// RUN: -frtlib-add-rpath \ // RUN: -frtlib-add-rpath \
// RUN: | FileCheck --check-prefixes=RESDIR,LIBPATH-X86_64,NO-RPATH %s // RUN: | FileCheck --check-prefixes=RESDIR,LIBPATH-X86_64,NO-RPATH %s
// //
// Add LIBPATH but no RPATH if no sanitizer or runtime is specified // Add LIBPATH but no RPATH if no sanitizer or runtime is specified
// RUN: %clang %s -### 2>&1 \ // RUN: %clang %s -### 2>&1 -target x86_64-linux \
// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \ // RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
// RUN: -frtlib-add-rpath \ // RUN: -frtlib-add-rpath \
// RUN: | FileCheck --check-prefixes=RESDIR,LIBPATH-X86_64,NO-RPATH %s // RUN: | FileCheck --check-prefixes=RESDIR,LIBPATH-X86_64,NO-RPATH %s
// //
// Do not add LIBPATH or RPATH if arch-specific subdir doesn't exist // Do not add LIBPATH or RPATH if arch-specific subdir doesn't exist
// RUN: %clang %s -### 2>&1 \ // RUN: %clang %s -### 2>&1 -target x86_64-linux \
// RUN: -resource-dir=%S/Inputs/resource_dir \ // RUN: -resource-dir=%S/Inputs/resource_dir \
// RUN: -frtlib-add-rpath \ // RUN: -frtlib-add-rpath \
// RUN: | FileCheck --check-prefixes=RESDIR,NO-LIBPATH,NO-RPATH %s // RUN: | FileCheck --check-prefixes=RESDIR,NO-LIBPATH,NO-RPATH %s
// //
// RESDIR: "-resource-dir" "[[RESDIR:[^ ]*]]" // RESDIR: "-resource-dir" "[[RESDIR:[^ ]*]]"
// LIBPATH-X86_64: -L[[RESDIR]]/lib/linux/x86_64 // LIBPATH-X86_64: -L[[RESDIR]]/lib/linux/x86_64
// RPATH-X86_64: "-rpath" "[[RESDIR]]/lib/linux/x86_64" // RPATH-X86_64: "-rpath" "[[RESDIR]]/lib/linux/x86_64"
// LIBPATH-AArch64: -L[[RESDIR]]/lib/linux/aarch64 // LIBPATH-AArch64: -L[[RESDIR]]/lib/linux/aarch64
// RPATH-AArch64: "-rpath" "[[RESDIR]]/lib/linux/aarch64" // RPATH-AArch64: "-rpath" "[[RESDIR]]/lib/linux/aarch64"
// NO-LIBPATH-NOT: -L{{.*}}Inputs/resource_dir // NO-LIBPATH-NOT: -L{{.*}}Inputs/resource_dir
// NO-RPATH-NOT: "-rpath" {{.*}}/Inputs/resource_dir // NO-RPATH-NOT: "-rpath" {{.*}}/Inputs/resource_dir