This is an archive of the discontinued LLVM Phabricator instance.

Normalize the LLVM cmake path before appending it to the module path
ClosedPublic

Authored by hughbe on Mar 13 2017, 9:08 PM.

Details

Summary

LLVM_CMAKE_PATH has backlashes in it. CMake then tries to append this to CMAKE_MODULE_PATH but gets confused and errors out as it thinks we're providing an escape sequence (that's unknown, causing generation to fail)

E.g "C:\Users\hugh..."

I've been porting swift to Windows/MSVC. This was causing the Windows build to fail and I submitted a PR (https://github.com/apple/swift-lldb/pull/156). Maybe it belongs upstream, however

Diff Detail

Repository
rL LLVM

Event Timeline

hughbe created this revision.Mar 13 2017, 9:08 PM
hughbe updated this revision to Diff 91668.Mar 13 2017, 9:09 PM

Fix preview

hughbe updated this revision to Diff 91676.Mar 13 2017, 9:59 PM

Address feedback from Zachary Turner

hughbe edited reviewers, added: zturner; removed: beanz.Mar 15 2017, 9:43 PM

As per discussion on lists

This revision was automatically updated to reflect the committed changes.