This is an archive of the discontinued LLVM Phabricator instance.

Differential D30711

[coroutines] update coro_end builtin to match llvm
ClosedPublic

Authored by GorNishanov on Mar 7 2017, 11:22 AM.

Details

Reviewers
GorNishanov
rsmith
Commits
rGc611ab251b15: [coroutines] update coro_end builtin to match llvm
rC297224: [coroutines] update coro_end builtin to match llvm
rL297224: [coroutines] update coro_end builtin to match llvm
Summary

llvm.coro.end intrinsic now returns bool. Updating clang to match it.

Diff Detail

Event Timeline

GorNishanov created this revision.Mar 7 2017, 11:22 AM
Herald added subscribers: EricWF, mehdi_amini. · View Herald TranscriptMar 7 2017, 11:22 AM
rsmith accepted this revision.Mar 7 2017, 11:23 AM
This revision is now accepted and ready to land.Mar 7 2017, 11:23 AM
Closed by commit rL297224: [coroutines] update coro_end builtin to match llvm (authored by GorNishanov). · Explain WhyMar 7 2017, 1:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
clang/
Basic/
2 lines
test/
CodeGenCoroutines/
2 lines

Diff 90897

include/clang/Basic/Builtins.def

Show First 20 Lines • Show All 1,359 Lines • ▼ Show 20 Lines
BUILTIN(__builtin_coro_size, "z", "n") BUILTIN(__builtin_coro_size, "z", "n")
BUILTIN(__builtin_coro_frame, "v*", "n") BUILTIN(__builtin_coro_frame, "v*", "n")
BUILTIN(__builtin_coro_free, "v*v*", "n") BUILTIN(__builtin_coro_free, "v*v*", "n")
BUILTIN(__builtin_coro_id, "v*Iiv*v*v*", "n") BUILTIN(__builtin_coro_id, "v*Iiv*v*v*", "n")
BUILTIN(__builtin_coro_alloc, "b", "n") BUILTIN(__builtin_coro_alloc, "b", "n")
BUILTIN(__builtin_coro_begin, "v*v*", "n") BUILTIN(__builtin_coro_begin, "v*v*", "n")
BUILTIN(__builtin_coro_end, "vv*Ib", "n") BUILTIN(__builtin_coro_end, "bv*Ib", "n")
BUILTIN(__builtin_coro_suspend, "cIb", "n") BUILTIN(__builtin_coro_suspend, "cIb", "n")
BUILTIN(__builtin_coro_param, "bv*v*", "n") BUILTIN(__builtin_coro_param, "bv*v*", "n")
// OpenCL v2.0 s6.13.16, s9.17.3.5 - Pipe functions. // OpenCL v2.0 s6.13.16, s9.17.3.5 - Pipe functions.
// We need the generic prototype, since the packet type could be anything. // We need the generic prototype, since the packet type could be anything.
LANGBUILTIN(read_pipe, "i.", "tn", OCLC20_LANG) LANGBUILTIN(read_pipe, "i.", "tn", OCLC20_LANG)
LANGBUILTIN(write_pipe, "i.", "tn", OCLC20_LANG) LANGBUILTIN(write_pipe, "i.", "tn", OCLC20_LANG)
LANGBUILTIN(reserve_read_pipe, "i.", "tn", OCLC20_LANG) LANGBUILTIN(reserve_read_pipe, "i.", "tn", OCLC20_LANG)
Show All 38 Lines

test/CodeGenCoroutines/coro-builtins.c

Show All 37 Linesvoid f(int n) {
// CHECK-NEXT: call i8* @llvm.coro.promise(i8* %[[FRAME4]], i32 48, i1 false) // CHECK-NEXT: call i8* @llvm.coro.promise(i8* %[[FRAME4]], i32 48, i1 false)
__builtin_coro_promise(__builtin_coro_frame(), 48, 0); __builtin_coro_promise(__builtin_coro_frame(), 48, 0);
// CHECK-NEXT: %[[FRAME5:.+]] = call i8* @llvm.coro.frame() // CHECK-NEXT: %[[FRAME5:.+]] = call i8* @llvm.coro.frame()
// CHECK-NEXT: call i8* @llvm.coro.free(token %[[COROID]], i8* %[[FRAME5]]) // CHECK-NEXT: call i8* @llvm.coro.free(token %[[COROID]], i8* %[[FRAME5]])
__builtin_coro_free(__builtin_coro_frame()); __builtin_coro_free(__builtin_coro_frame());
// CHECK-NEXT: %[[FRAME6:.+]] = call i8* @llvm.coro.frame() // CHECK-NEXT: %[[FRAME6:.+]] = call i8* @llvm.coro.frame()
// CHECK-NEXT: call void @llvm.coro.end(i8* %[[FRAME6]], i1 false) // CHECK-NEXT: call i1 @llvm.coro.end(i8* %[[FRAME6]], i1 false)
__builtin_coro_end(__builtin_coro_frame(), 0); __builtin_coro_end(__builtin_coro_frame(), 0);
// CHECK-NEXT: call i8 @llvm.coro.suspend(token none, i1 true) // CHECK-NEXT: call i8 @llvm.coro.suspend(token none, i1 true)
__builtin_coro_suspend(1); __builtin_coro_suspend(1);
// CHECK-NEXT: %[[N_ADDR:.+]] = bitcast i32* %n.addr to i8* // CHECK-NEXT: %[[N_ADDR:.+]] = bitcast i32* %n.addr to i8*
// CHECK-NEXT: %[[N_COPY_ADDR:.+]] = bitcast i32* %n_copy to i8* // CHECK-NEXT: %[[N_COPY_ADDR:.+]] = bitcast i32* %n_copy to i8*
// CHECK-NEXT: call i1 @llvm.coro.param(i8* %[[N_ADDR]], i8* %[[N_COPY_ADDR]]) // CHECK-NEXT: call i1 @llvm.coro.param(i8* %[[N_ADDR]], i8* %[[N_COPY_ADDR]])
__builtin_coro_param(&n, &n_copy); __builtin_coro_param(&n, &n_copy);
} }