Page MenuHomePhabricator

[libcxxabi] Fix condition typo in rL296136
ClosedPublic

Authored by rs on Feb 24 2017, 9:56 AM.

Details

Summary

Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always defined, I should have been checking the contents to see if it's enabled

Diff Detail

Repository
rL LLVM

Event Timeline

rs created this revision.Feb 24 2017, 9:56 AM
rs added a comment.Feb 24 2017, 10:31 AM

Going for post-commit.

This revision was automatically updated to reflect the committed changes.
EricWF edited edge metadata.EditedFeb 24 2017, 12:27 PM

This works for me, but the idiomatic macro usage in libc++, and (hopefully) libc++abi should always use !defined(FOO) as opposed to !FOO. I'll clean this up in the next week if nobody else wants to.

rs added a comment.Feb 27 2017, 5:17 AM

This works for me, but the idiomatic macro usage in libc++, and (hopefully) libc++abi should always use !defined(FOO) as opposed to !FOO. I'll clean this up in the next week if nobody else wants to.

I can do the clean up later this week.