[X86] Clean up test/CodeGen/X86/2006-03-01-InstrSchedBug.ll

[jgorbe]

Summary

• Migrated from grep to FileCheck.
• Re-indented, removed boilerplate comments.
• Added 'entry' label at beginning of basic block.

[RKSimon]

test/CodeGen/X86/2006-03-01-InstrSchedBug.ll

1 ↗

(On Diff #89591)

Might as well regenerate the test file with the update script

3 ↗

(On Diff #89591)

For a trivial test like this removing the -march and replacing with this triple (-mtriple=i686-unknown-unknown) will tidy things up more.

6 ↗

(On Diff #89591)

I'd recommend not adding this as it might affect the reproducibility of the exact codegen that caused the old bug (unlikely but maybe).

[jgorbe]

• Regenerated the test with update_llc_test_checks.py
• Specified target triple in the RUN: line with -mtriple
• Removed entry label added in the previous version of the patch.

Thanks for the review! (and sorry it took me so long to respond)

[RKSimon]

test/CodeGen/X86/2006-03-01-InstrSchedBug.ll

3 ↗

(On Diff #89591)

Still no -mtriple ?

[jgorbe]

Added -mtriple parameter to the RUN line. I messed up when regenerating the test with the script, reverted it, and lost the edit I had done before. Thanks for noticing.

[RKSimon]

LGTM

llvm/trunk/test/CodeGen/X86/2006-03-01-InstrSchedBug.ll

-; RUN: llc < %s -march=x86 | not grep "subl.*%esp"
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=i686-unknown-unknown | FileCheck %s
 
 define i32 @f(i32 %a, i32 %b) {
-        %tmp.2 = mul i32 %a, %a         ; <i32> [#uses=1]
-        %tmp.5 = shl i32 %a, 1          ; <i32> [#uses=1]
-        %tmp.6 = mul i32 %tmp.5, %b             ; <i32> [#uses=1]
-        %tmp.10 = mul i32 %b, %b                ; <i32> [#uses=1]
-        %tmp.7 = add i32 %tmp.10, %tmp.2                ; <i32> [#uses=1]
-        %tmp.11 = add i32 %tmp.7, %tmp.6                ; <i32> [#uses=1]
-        ret i32 %tmp.11
+; CHECK-LABEL: f:
+; CHECK:       # BB#0:
+; CHECK-NEXT:    movl {{[0-9]+}}(%esp), %eax
+; CHECK-NEXT:    movl {{[0-9]+}}(%esp), %ecx
+; CHECK-NEXT:    movl %ecx, %edx
+; CHECK-NEXT:    imull %edx, %edx
+; CHECK-NEXT:    imull %eax, %ecx
+; CHECK-NEXT:    imull %eax, %eax
+; CHECK-NEXT:    addl %edx, %eax
+; CHECK-NEXT:    leal (%eax,%ecx,2), %eax
+; CHECK-NEXT:    retl
+  %tmp.2 = mul i32 %a, %a
+  %tmp.5 = shl i32 %a, 1
+  %tmp.6 = mul i32 %tmp.5, %b
+  %tmp.10 = mul i32 %b, %b
+  %tmp.7 = add i32 %tmp.10, %tmp.2
+  %tmp.11 = add i32 %tmp.7, %tmp.6
 }