Replace backslashes with forward slashes

[zturner]

Summary

CMake doesn't seem to like when paths have backslashes in them, so replacing them all with forward slashes.

Not sure if there's a better way to accomplish this. This is leading to failures such as here:

http://lab.llvm.org:8011/builders/sanitizer-windows/builds/6620/steps/cmake_1/logs/stdio

[zturner]

Actually this isn't going to work because %workdir isn't even evaluated yet. Galina, do you know how to get the working directory with forward slashes instead of backslashes?

[gkistanova]

Hi Zachary,

Unfortunately, this wouldn't work as you expect it to. The back slashes come from the %(workdir)s which gets rendered far away from this point.

The right fix should be in cmake to normalize the input paths by converting it with file(TO_CMAKE_PATH,...).

Anyway, it seems we were looking at the same problem at the same time. I have committed a workaround for this issue in https://reviews.llvm.org/rL295785. Hope that will let you go further with your builder.

[gkistanova]

Galina, do you know how to get the working directory with forward slashes instead of backslashes?

Currently we could get it either with mixed slashes (backslashes from rendering %(workdir)s), or all forward slashes.

Having paths with all forward slashes, you wouldn't be able to set some env vars, like PATH, for example, unless you want to go with a custom renderer in some cases.

zorg/buildbot/builders/SanitizerBuilderWindows.py

def getSanitizerWindowsBuildFactory(
 
     # Update slave_env to add fresh clang, tools and compiler-rt dlls to path.
     update_path_cmd = "set Path="+bin_path+";"+dll_path+";%%Path%% && set"
     f.addStep(SetProperty(command=WithProperties(update_path_cmd),
                           extract_fn=extractSlaveEnvironment,
                           env=Property('slave_env')))
 
     # Get absolute path to clang-cl.
-    clang_cl = "%(workdir)s/" + build_dir + "/bin/clang-cl"
+    clang_cl = ("%(workdir)s/" + build_dir + "/bin/clang-cl").replace("\\", "/")
     f.addStep(ShellCommand(name='cmake',
                            command=[cmake, "-G", "Ninja", "../llvm",
                                "-DCMAKE_BUILD_TYPE="+config,
                                "-DLLVM_ENABLE_ASSERTIONS=ON",
                                WithProperties("-DCMAKE_C_COMPILER="+clang_cl),
                                WithProperties("-DCMAKE_CXX_COMPILER="+clang_cl),
                                "-DLLVM_USE_SANITIZER=Address",
                                "-DLLVM_USE_SANITIZE_COVERAGE=YES"]