This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Insert linkerscript symbols directly into symbol table
ClosedPublic

Authored by phosek on Feb 21 2017, 1:58 PM.

Details

Summary

This change exposes the symbol table insert method and uses it to insert the linkerscript defined symbols directly into the symbol table to avoid unnecessarily pulling the object out of an archive.

This change addresses PR32026.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Feb 21 2017, 1:58 PM
ruiu accepted this revision.Feb 21 2017, 2:14 PM

LGTM

test/ELF/linkerscript/Inputs/lazy-symbols.s
3–7

You don't need to make symbol` foo` have real contents, so you can remove this.

test/ELF/linkerscript/lazy-symbols.s
2

Please add a comment to say that this test is to make sure that a linker script can define a symbol which have the same name as a lazy symbol.

This revision is now accepted and ready to land.Feb 21 2017, 2:14 PM
phosek updated this revision to Diff 89281.Feb 21 2017, 2:37 PM
phosek marked 2 inline comments as done.
This revision was automatically updated to reflect the committed changes.