This is an archive of the discontinued LLVM Phabricator instance.

Differential D29888

Fix debug build of unit tests
ClosedPublic

Authored by labath on Feb 13 2017, 3:45 AM.

Details

Reviewers
beanz
Commits
rGcf8af0ad6145: Fix debug build of unit tests
rLLDB295189: Fix debug build of unit tests
rL295189: Fix debug build of unit tests
Summary

It turns out listing each library twice is not enough to resolve all
references in a debug build on linux - a number of executables fails to
link with random symbols missing. Increasing the number to three seems
to be enough. The choice of lldbCore to set the multiplicity on is
somewhat arbitrary, but it seems fitting, as it is the biggest layering
transgressor.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Feb 13 2017, 3:45 AM
Harbormaster completed remote builds in B3919: Diff 88177.Feb 13 2017, 3:45 AM
Herald added a subscriber: mgorny. · View Herald TranscriptFeb 13 2017, 3:45 AM
Closed by commit rL295189: Fix debug build of unit tests (authored by labath). · Explain WhyFeb 15 2017, 8:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
source/
Core/
3 lines

Diff 88544

lldb/trunk/source/Core/CMakeLists.txt

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Lines LINK_LIBS
lldbPluginObjectFileJIT lldbPluginObjectFileJIT
lldbPluginExpressionParserClang lldbPluginExpressionParserClang
LINK_COMPONENTS LINK_COMPONENTS
Support Support
Demangle Demangle
) )
# Needed to properly resolve references in a debug build.
# TODO: Remove once we have better layering
set_target_properties(lldbCore PROPERTIES LINK_INTERFACE_MULTIPLICITY 3)