This is an archive of the discontinued LLVM Phabricator instance.

Differential D29860

[XRay] [compiler-rt] [NFC] Annotate unused variables for the compiler.
ClosedPublic

Authored by pelikan on Feb 10 2017, 7:19 PM.

Details

Reviewers
dberris
Commits
rGfbe64b65a895: [XRay] [compiler-rt] [NFC] Annotate unused variables for the compiler.
rCRT296449: [XRay] [compiler-rt] [NFC] Annotate unused variables for the compiler.
rL296449: [XRay] [compiler-rt] [NFC] Annotate unused variables for the compiler.
Summary

Use a common definition of a "this variable is unused" annotation for useless
variables only present for their lambda global initializers, to silence gcc's
warning.

Diff Detail

Repository
rL LLVM

Event Timeline

pelikan created this revision.Feb 10 2017, 7:19 PM
dberris added inline comments.Feb 13 2017, 9:56 AM
lib/xray/xray_fdr_logging.cc
526 ↗(On Diff #88079)

Where does UNUSED come from?

pelikan updated this revision to Diff 89016.Feb 17 2017, 9:57 PM

sync

Harbormaster completed remote builds in B4106: Diff 89016.Feb 17 2017, 9:57 PM
pelikan marked an inline comment as done.Feb 17 2017, 10:08 PM
pelikan added inline comments.
lib/xray/xray_fdr_logging.cc
526 ↗(On Diff #88079)

$ git grep UNUSED | grep \#define
lib/builtins/int_lib.h:#define UNUSED
lib/builtins/int_lib.h:#define UNUSED attribute((unused))

This comes from the sanitizer_common header set.

dberris accepted this revision.Feb 19 2017, 7:51 PM
dberris added inline comments.
lib/xray/xray_fdr_logging.cc
526 ↗(On Diff #88079)

Don't you need to include a header to get that definition?

This revision is now accepted and ready to land.Feb 19 2017, 7:51 PM
Closed by commit rL296449: [XRay] [compiler-rt] [NFC] Annotate unused variables for the compiler. (authored by dberris). · Explain WhyFeb 28 2017, 1:00 AM
This revision was automatically updated to reflect the committed changes.
dberris added inline comments.Feb 28 2017, 1:01 AM
lib/xray/xray_fdr_logging.cc
526 ↗(On Diff #88079)

Apparently not. Landed without further changes after local testing.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
xray/
2 lines
2 lines

Diff 89987

compiler-rt/trunk/lib/xray/xray_fdr_logging.cc

Show First 20 Lines • Show All 517 Lines • ▼ Show 20 Lines if (auto EC = LocalBQ->releaseBuffer(Buffer)) {
return; return;
} }
RecordPtr = nullptr; RecordPtr = nullptr;
} }
} }
} // namespace __xray } // namespace __xray
static auto Unused = [] { static auto UNUSED Unused = [] {
using namespace __xray; using namespace __xray;
if (flags()->xray_fdr_log) { if (flags()->xray_fdr_log) {
XRayLogImpl Impl{ XRayLogImpl Impl{
fdrLoggingInit, fdrLoggingFinalize, fdrLoggingHandleArg0, fdrLoggingInit, fdrLoggingFinalize, fdrLoggingHandleArg0,
fdrLoggingFlush, fdrLoggingFlush,
}; };
__xray_set_log_impl(Impl); __xray_set_log_impl(Impl);
} }
return true; return true;
}(); }();

compiler-rt/trunk/lib/xray/xray_inmemory_log.cc

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Lines if (Offset == BuffLen) {
std::lock_guard<std::mutex> L(LogMutex); std::lock_guard<std::mutex> L(LogMutex);
auto RecordBuffer = reinterpret_cast<__xray::XRayRecord *>(InMemoryBuffer); auto RecordBuffer = reinterpret_cast<__xray::XRayRecord *>(InMemoryBuffer);
retryingWriteAll(Fd, reinterpret_cast<char *>(RecordBuffer), retryingWriteAll(Fd, reinterpret_cast<char *>(RecordBuffer),
reinterpret_cast<char *>(RecordBuffer + Offset)); reinterpret_cast<char *>(RecordBuffer + Offset));
Offset = 0; Offset = 0;
} }
} }
static auto Unused = [] { static auto UNUSED Unused = [] {
if (!probeRequiredCPUFeatures()) { if (!probeRequiredCPUFeatures()) {
Report("Required CPU features missing for XRay instrumentation, not " Report("Required CPU features missing for XRay instrumentation, not "
"installing instrumentation hooks.\n"); "installing instrumentation hooks.\n");
return false; return false;
} }
if (flags()->xray_naive_log) if (flags()->xray_naive_log)
__xray_set_handler(__xray_InMemoryRawLog); __xray_set_handler(__xray_InMemoryRawLog);
return true; return true;
}(); }();