This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][asan|win] Force tls_init test to use dynamic runtime
ClosedPublic

Authored by etienneb on Feb 10 2017, 10:59 AM.

Reviewers

• chrisha
rnk

Commits

Summary

There is no guarantee that the tls_init is executed on the static runtime
(/MT).

On windows 7, this unittest is failing.
On windows 10, I believe it's working because of the new CRT.

On ASAN side, it doesn't matter that the hook point is run or not.
It must be run only if there is other tls_initializer that are registered.

Build Status

Buildable 3881
Build 3881: arc lint + arc unit

PTAL

lgtm

This revision is now accepted and ready to land.Feb 13 2017, 10:47 AM

Path

Size

test/

asan/

TestCases/

Windows/

2 lines

	// RUN: %clang_cl_asan %s -Fe%t.exe			// RUN: %clang_cl_asan %s -Fe%t.exe /MD
	// RUN: %run %t.exe \| FileCheck %s			// RUN: %run %t.exe \| FileCheck %s

	// CHECK: my_thread_callback			// CHECK: my_thread_callback
	// CHECK: ran_before_main: 1			// CHECK: ran_before_main: 1

	#include <windows.h>			#include <windows.h>
	#include <stdio.h>			#include <stdio.h>
	#include <string.h>			#include <string.h>
	▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines