Page MenuHomePhabricator

[Polly] Check reduction dependencies in case of the matrix multiplication optimization
ClosedPublic

Authored by gareevroman on Feb 10 2017, 12:30 AM.

Details

Summary

To determine parameters of the matrix multiplication, we check RAW dependencies that can be expressed using only reduction dependencies. Consequently, we should check the reduction dependencies, if this is the case.

Diff Detail

Repository
rL LLVM

Event Timeline

gareevroman created this revision.Feb 10 2017, 12:30 AM
grosser edited edge metadata.Feb 10 2017, 12:33 AM

Otherwise, this looks good to me.

Some of the lower changes seem to be mostly stylistic. In case they are, I suggest to commit them ahead of time and then add the actual functionality change separately. In case it introduces a bug, the surface is smaller.

lib/Transform/ScheduleOptimizer.cpp
772 ↗(On Diff #87968)

Would it make sense to just compute the union of both?

grosser accepted this revision.Feb 10 2017, 12:33 AM
This revision is now accepted and ready to land.Feb 10 2017, 12:33 AM
Meinersbur added inline comments.Feb 10 2017, 9:26 AM
lib/Transform/ScheduleOptimizer.cpp
782 ↗(On Diff #87968)

This change seems unrelated

2017-02-10 13:33 GMT+05:00 Tobias Grosser via Phabricator <reviews@reviews.llvm.org>:

grosser added a comment.

Otherwise, this looks good to me.

Some of the lower changes seem to be mostly stylistic. In case they are, I suggest to commit them ahead of time and then add the actual functionality change separately. In case it introduces a bug, the surface is smaller.

2017-02-10 13:43 GMT+05:00 Sven Verdoolaege <skimo-polly@kotnet.org>:

You're computing the domain of a schedule just to get its space?!??
Get the domain of the space instead.

2017-02-10 22:26 GMT+05:00 Michael Kruse via Phabricator <reviews@reviews.llvm.org>:

This change seems unrelated

Thanks for the comments! Stylistic changes can be found in r294831.

This revision was automatically updated to reflect the committed changes.