This is an archive of the discontinued LLVM Phabricator instance.

Differential D29802

opt-viewer: fix HtmlFormatter encoding
ClosedPublic

Authored by bcain on Feb 9 2017, 5:29 PM.

Details

Reviewers
anemet
fhahn
Commits
rG386cd3dd6bae: opt-viewer: fix HtmlFormatter encoding
rL294710: opt-viewer: fix HtmlFormatter encoding
Summary

Small fix to HtmlFormatter, defaults to ascii encoding, so utf-8 output may get UnicodeEncodeError: 'ascii' codec can't encode character ... ordinal not in range(128) during write.

Diff Detail

Repository
rL LLVM

Event Timeline

bcain created this revision.Feb 9 2017, 5:29 PM
anemet accepted this revision.Feb 9 2017, 5:30 PM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 9 2017, 5:30 PM
Closed by commit rL294710: opt-viewer: fix HtmlFormatter encoding (authored by anemet). · Explain WhyFeb 9 2017, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
utils/
opt-viewer/
2 lines

Diff 87924

utils/opt-viewer/opt-viewer.py

Context not available.
</html> </html>
'''.format(filename), file=self.stream) '''.format(filename), file=self.stream)
self.html_formatter = HtmlFormatter() self.html_formatter = HtmlFormatter(encoding='utf-8')
self.cpp_lexer = CppLexer() self.cpp_lexer = CppLexer()
def render_source_line(self, linenum, line): def render_source_line(self, linenum, line):
Context not available.