This is an archive of the discontinued LLVM Phabricator instance.

list paths explicitly instead of using * in test/COFF/savetemps.ll
ClosedPublic

Authored by inglorion on Feb 9 2017, 2:07 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

inglorion created this revision.Feb 9 2017, 2:07 PM
ruiu edited edge metadata.Feb 9 2017, 2:13 PM

How about creating a temporary subdirectory (e.g. %T/tmp/) and remove that directory entirely? I think it is better than deleting individual files.

How about creating a temporary subdirectory (e.g. %T/tmp/) and remove that directory entirely?

WE CAN DO THAT?!

Seriously though, good idea.

inglorion updated this revision to Diff 87883.Feb 9 2017, 2:28 PM

use a subdirectory

ruiu accepted this revision.Feb 9 2017, 2:37 PM

LGTM

This revision is now accepted and ready to land.Feb 9 2017, 2:37 PM
dyung accepted this revision.Feb 9 2017, 2:41 PM

LGTM me as well. I tried the rm/mkdir options that you added and they worked (did not return an error) on my Windows machine both with the subdirectory present and without it present.

This revision was automatically updated to reflect the committed changes.