This is an archive of the discontinued LLVM Phabricator instance.

Declare lgamma library builtins as never being const
ClosedPublic

Authored by jgravelle-google on Feb 9 2017, 11:35 AM.

Details

Summary

POSIX requires lgamma writes to an external global variable, signgam.
This prevents annotating lgamma with readnone, which is incorrect on
targets that write to signgam.

Event Timeline

efriedma added inline comments.Feb 15 2017, 11:38 AM
include/clang/Basic/Builtins.def
1091

Please add a comment explaining why this doesn't have an "e" marking.

  • Add comment to lgamma builtins
jgravelle-google marked an inline comment as done.Feb 15 2017, 4:58 PM

Thanks, added a comment

hfinkel accepted this revision.Feb 15 2017, 7:00 PM
hfinkel added a subscriber: hfinkel.

LGTM

This revision is now accepted and ready to land.Feb 15 2017, 7:00 PM
This revision was automatically updated to reflect the committed changes.