Page MenuHomePhabricator

[sancov] specifying comdat for sancov constructors
ClosedPublic

Authored by aizatsky on Feb 7 2017, 9:34 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

aizatsky created this revision.Feb 7 2017, 9:34 AM
aizatsky updated this revision to Diff 87485.Feb 7 2017, 11:18 AM

Updated ctor registration.

aizatsky updated this revision to Diff 87681.EditedFeb 8 2017, 11:12 AM

update

kcc edited edge metadata.Feb 8 2017, 11:45 AM

code ok, but please add a lit test, e.g. extend test/Instrumentation/SanitizerCoverage/coverage.ll or some other nearby

aizatsky updated this revision to Diff 87693.Feb 8 2017, 12:42 PM

added .ll test

I've added the test. PTAL.

kcc accepted this revision.Feb 8 2017, 12:44 PM

LGTM

This revision is now accepted and ready to land.Feb 8 2017, 12:44 PM
This revision was automatically updated to reflect the committed changes.

Grhhh. Fails on mac :(

fatal error: error in backend: MachO doesn't support COMDATs, 'sancov.module_ctor' cannot be lowered.

I'll rollback and will see what I can do.