This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Simplify test to work on windows.
ClosedPublic

Authored by mpividori on Feb 3 2017, 10:29 PM.

Download Raw Diff

Details

Reviewers

kcc
zturner

Commits

rG4a65bc35c37f: [libFuzzer] Simplify dump_coverage test.
rL294379: [libFuzzer] Simplify dump_coverage test.

Summary

Environment variables are handled differently on Windows.
In this case it is not necessary to use environment variables. So, I simplify the test to work on Windows.

Diff Detail

Event Timeline

mpividori created this revision.Feb 3 2017, 10:29 PM

nope. this way the test will race with other tests that will create sancov files in $PWD

The test as is is also not very good. Instead of BUILDDIR it should be using ASAN_OPTIONS=coverage_dir=PATH or some such

@kcc Let me know if you agree with this new diff.
Thanks.

kcc added inline comments.Feb 6 2017, 3:40 PM

lib/Fuzzer/test/dump_coverage.test
4	use env ASAN_OPTIONS=coverage_dir='"%t_workdir"' in all the lines below to avoid races on output files.

mpividori updated this revision to Diff 87329.Feb 6 2017, 3:51 PM

LGTM

This revision is now accepted and ready to land.Feb 7 2017, 1:21 PM

Closed by commit rL294379: [libFuzzer] Simplify dump_coverage test. (authored by mpividori). · Explain WhyFeb 7 2017, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Fuzzer/

test/

dump_coverage.test

13 lines

Diff 87077

lib/Fuzzer/test/dump_coverage.test

	RUN: DIR=%t_workdir			RUN: rm -f *.sancov
	RUN: BUILD_DIR=$(pwd)			RUN: not LLVMFuzzer-NullDerefTest -dump_coverage=1 2>&1 \| FileCheck %s
	RUN: rm -rf $DIR && mkdir -p $DIR && cd $DIR			RUN: ls .sancov \| xargs sancov -covered-functions LLVMFuzzer-NullDerefTest \| FileCheck %s --check-prefix=SANCOV
	RUN: not $BUILD_DIR/LLVMFuzzer-NullDerefTest -dump_coverage=1 2>&1 \| FileCheck %s			RUN: LLVMFuzzer-DSOTest -dump_coverage=1 -runs=0 2>&1 \| FileCheck %s --check-prefix=DSO
				kccUnsubmitted Not Done Reply Inline Actions use env ASAN_OPTIONS=coverage_dir='"%t_workdir"' in all the lines below to avoid races on output files. kcc: use env ASAN_OPTIONS=coverage_dir='"%t_workdir"' in all the lines below to avoid races on…
	RUN: ls .sancov \| xargs sancov -covered-functions $BUILD_DIR/LLVMFuzzer-NullDerefTest \| FileCheck %s --check-prefix=SANCOV			RUN: not LLVMFuzzer-NullDerefTest -dump_coverage=0 2>&1 \| FileCheck %s --check-prefix=NOCOV
	RUN: $BUILD_DIR/LLVMFuzzer-DSOTest -dump_coverage=1 -runs=0 2>&1 \| FileCheck %s --check-prefix=DSO
	RUN: not $BUILD_DIR/LLVMFuzzer-NullDerefTest -dump_coverage=0 2>&1 \| FileCheck %s --check-prefix=NOCOV
	RUN: rm -rf $DIR


	CHECK: SanitizerCoverage: ./LLVMFuzzer-NullDerefTest.{{.}}.sancov {{.}} PCs written			CHECK: SanitizerCoverage: ./LLVMFuzzer-NullDerefTest.{{.}}.sancov {{.}} PCs written
	SANCOV: LLVMFuzzerTestOneInput			SANCOV: LLVMFuzzerTestOneInput

	DSO: SanitizerCoverage: ./LLVMFuzzer-DSOTest.{{.}}.sancov {{.}} PCs written			DSO: SanitizerCoverage: ./LLVMFuzzer-DSOTest.{{.}}.sancov {{.}} PCs written
	DSO-DAG: SanitizerCoverage: {{.}}LLVMFuzzer-DSO1.{{.}}.sancov {{.*}} PCs written			DSO-DAG: SanitizerCoverage: {{.}}LLVMFuzzer-DSO1.{{.}}.sancov {{.*}} PCs written
	DSO-DAG: SanitizerCoverage: {{.}}LLVMFuzzer-DSO2.{{.}}.sancov {{.*}} PCs written			DSO-DAG: SanitizerCoverage: {{.}}LLVMFuzzer-DSO2.{{.}}.sancov {{.*}} PCs written

	NOCOV-NOT: SanitizerCoverage: {{.*}} PCs written			NOCOV-NOT: SanitizerCoverage: {{.*}} PCs written