This is an archive of the discontinued LLVM Phabricator instance.

Differential D29531

[libFuzzer] Consider exception names on tests.
ClosedPublic

Authored by mpividori on Feb 3 2017, 10:18 PM.

Details

Reviewers
kcc
zturner
Commits
rG51f907f3a4a9: [libFuzzer] Update test to consider different exceptions.
rL294377: [libFuzzer] Update test to consider different exceptions.

Diff Detail

Event Timeline

mpividori created this revision.Feb 3 2017, 10:18 PM
kcc added inline comments.Feb 6 2017, 11:15 AM
lib/Fuzzer/test/value-profile-load.test
1

why?

mpividori updated this revision to Diff 87291.Feb 6 2017, 1:26 PM

You are right. I found the reason of the difference between global and stack buffer overflow. It was fixed in: https://reviews.llvm.org/D29602

mpividori added a comment.Feb 6 2017, 2:40 PM

@kcc now it looks good?

kcc accepted this revision.Feb 6 2017, 3:41 PM

LGTM

This revision is now accepted and ready to land.Feb 6 2017, 3:41 PM
Closed by commit rL294377: [libFuzzer] Update test to consider different exceptions. (authored by mpividori). · Explain WhyFeb 7 2017, 4:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Fuzzer/
test/
2 lines
2 lines
2 lines

Diff 87073

lib/Fuzzer/test/fuzzer.test

CHECK: BINGO CHECK: BINGO
Done1000000: Done 1000000 runs in Done1000000: Done 1000000 runs in
RUN: LLVMFuzzer-SimpleTest 2>&1 | FileCheck %s RUN: LLVMFuzzer-SimpleTest 2>&1 | FileCheck %s
# only_ascii mode. Will perform some minimal self-validation. # only_ascii mode. Will perform some minimal self-validation.
RUN: LLVMFuzzer-SimpleTest -only_ascii=1 2>&1 RUN: LLVMFuzzer-SimpleTest -only_ascii=1 2>&1
RUN: LLVMFuzzer-SimpleCmpTest -max_total_time=1 -use_cmp=0 2>&1 | FileCheck %s --check-prefix=MaxTotalTime RUN: LLVMFuzzer-SimpleCmpTest -max_total_time=1 -use_cmp=0 2>&1 | FileCheck %s --check-prefix=MaxTotalTime
MaxTotalTime: Done {{.*}} runs in {{.}} second(s) MaxTotalTime: Done {{.*}} runs in {{.}} second(s)
RUN: not LLVMFuzzer-NullDerefTest 2>&1 | FileCheck %s --check-prefix=NullDerefTest RUN: not LLVMFuzzer-NullDerefTest 2>&1 | FileCheck %s --check-prefix=NullDerefTest
RUN: not LLVMFuzzer-NullDerefTest -close_fd_mask=3 2>&1 | FileCheck %s --check-prefix=NullDerefTest RUN: not LLVMFuzzer-NullDerefTest -close_fd_mask=3 2>&1 | FileCheck %s --check-prefix=NullDerefTest
NullDerefTest: ERROR: AddressSanitizer: SEGV on unknown address NullDerefTest: ERROR: AddressSanitizer: {{SEGV|access-violation}} on unknown address
NullDerefTest: Test unit written to ./crash- NullDerefTest: Test unit written to ./crash-
RUN: not LLVMFuzzer-NullDerefTest -artifact_prefix=ZZZ 2>&1 | FileCheck %s --check-prefix=NullDerefTestPrefix RUN: not LLVMFuzzer-NullDerefTest -artifact_prefix=ZZZ 2>&1 | FileCheck %s --check-prefix=NullDerefTestPrefix
NullDerefTestPrefix: Test unit written to ZZZcrash- NullDerefTestPrefix: Test unit written to ZZZcrash-
RUN: not LLVMFuzzer-NullDerefTest -artifact_prefix=ZZZ -exact_artifact_path=FOOBAR 2>&1 | FileCheck %s --check-prefix=NullDerefTestExactPath RUN: not LLVMFuzzer-NullDerefTest -artifact_prefix=ZZZ -exact_artifact_path=FOOBAR 2>&1 | FileCheck %s --check-prefix=NullDerefTestExactPath
NullDerefTestExactPath: Test unit written to FOOBAR NullDerefTestExactPath: Test unit written to FOOBAR
RUN: not LLVMFuzzer-NullDerefOnEmptyTest -print_final_stats=1 2>&1 | FileCheck %s --check-prefix=NULL_DEREF_ON_EMPTY RUN: not LLVMFuzzer-NullDerefOnEmptyTest -print_final_stats=1 2>&1 | FileCheck %s --check-prefix=NULL_DEREF_ON_EMPTY
NULL_DEREF_ON_EMPTY: stat::number_of_executed_units: NULL_DEREF_ON_EMPTY: stat::number_of_executed_units:
Show All 38 Lines

lib/Fuzzer/test/value-profile-div.test

CHECK: AddressSanitizer: FPE CHECK: AddressSanitizer: {{FPE|int-divide-by-zero}}
RUN: not LLVMFuzzer-DivTest -seed=1 -use_value_profile=1 -runs=10000000 2>&1 | FileCheck %s RUN: not LLVMFuzzer-DivTest -seed=1 -use_value_profile=1 -runs=10000000 2>&1 | FileCheck %s

lib/Fuzzer/test/value-profile-load.test

CHECK: AddressSanitizer: global-buffer-overflow CHECK: AddressSanitizer: {{stack|global}}-buffer-overflow
kccUnsubmitted
Not Done
ReplyInline Actions

why?

kcc: why?
RUN: not LLVMFuzzer-LoadTest -seed=1 -use_cmp=0 -use_value_profile=1 -runs=10000000 2>&1 | FileCheck %s RUN: not LLVMFuzzer-LoadTest -seed=1 -use_cmp=0 -use_value_profile=1 -runs=10000000 2>&1 | FileCheck %s