This is an archive of the discontinued LLVM Phabricator instance.

FunctionImport: Remove the -disable-force-link-odr flag and change importFunctions to never force link.
ClosedPublic

Authored by pcc on Feb 1 2017, 9:50 PM.

Event Timeline

pcc created this revision.Feb 1 2017, 9:50 PM
mehdi_amini edited edge metadata.Feb 1 2017, 10:04 PM

What changed that makes it no longer needed?
I had to add this flag because this test was relying on this behavior (here https://reviews.llvm.org/D19096#inline-162741 )

mehdi_amini accepted this revision.Feb 1 2017, 10:07 PM

LGTM anyway

This revision is now accepted and ready to land.Feb 1 2017, 10:07 PM
pcc added a comment.Feb 2 2017, 10:51 AM

What changed that makes it no longer needed?
I had to add this flag because this test was relying on this behavior (here https://reviews.llvm.org/D19096#inline-162741 )

I gather that at the time the gold plugin and ThinLTOCodeGenerator were using force-link-odr and we needed some way to test it.

This revision was automatically updated to reflect the committed changes.