This is an archive of the discontinued LLVM Phabricator instance.

Differential D29420

[libFuzzer] Isolate merge tests that require posix.
ClosedPublic

Authored by mpividori on Feb 1 2017, 1:32 PM.

Details

Reviewers
kcc
zturner
Commits
rGb05687970058: [libFuzzer] Isolate merge tests that require posix.
rL293828: [libFuzzer] Isolate merge tests that require posix.

Diff Detail

Event Timeline

mpividori created this revision.Feb 1 2017, 1:32 PM
kcc accepted this revision.Feb 1 2017, 1:44 PM

LGTM with two nits

lib/Fuzzer/test/merge-posix.test
1

you don't need this line

17

put REQUIRES at the top

This revision is now accepted and ready to land.Feb 1 2017, 1:44 PM
kcc added a comment.Feb 1 2017, 1:45 PM

split like this is totally fine for me

Closed by commit rL293828: [libFuzzer] Isolate merge tests that require posix. (authored by mpividori). · Explain WhyFeb 1 2017, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Fuzzer/
test/
17 lines
8 lines

Diff 86706

lib/Fuzzer/test/merge-posix.test

  • This file was added.
CHECK: BINGO
kccUnsubmitted
Not Done
ReplyInline Actions

you don't need this line

kcc: you don't need this line
RUN: rm -rf %tmp/T1 %tmp/T2
RUN: mkdir -p %tmp/T1 %tmp/T2
RUN: echo F..... > %tmp/T1/1
RUN: echo .U.... > %tmp/T1/2
RUN: echo ..Z... > %tmp/T1/3
# Check that we honor TMPDIR
RUN: TMPDIR=DIR_DOES_NOT_EXIST not LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=TMPDIR
TMPDIR: MERGE-OUTER: failed to write to the control file: DIR_DOES_NOT_EXIST/libFuzzerTemp
# Check that we can report an error if file size exceeded
RUN: (ulimit -f 1; not LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=SIGXFSZ)
SIGXFSZ: ERROR: libFuzzer: file size exceeded
REQUIRES: posix
kccUnsubmitted
Not Done
ReplyInline Actions

put REQUIRES at the top

kcc: put REQUIRES at the top

lib/Fuzzer/test/merge.test

Show All 39 Lines
RUN: LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=MERGE_WITH_CRASH RUN: LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=MERGE_WITH_CRASH
MERGE_WITH_CRASH: MERGE-OUTER: succesfull in 2 attempt(s) MERGE_WITH_CRASH: MERGE-OUTER: succesfull in 2 attempt(s)
MERGE_WITH_CRASH: MERGE-OUTER: 3 new files MERGE_WITH_CRASH: MERGE-OUTER: 3 new files
# Check that we actually limit the size with max_len # Check that we actually limit the size with max_len
RUN: LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 -max_len=5 2>&1 | FileCheck %s --check-prefix=MERGE_LEN5 RUN: LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 -max_len=5 2>&1 | FileCheck %s --check-prefix=MERGE_LEN5
MERGE_LEN5: MERGE-OUTER: succesfull in 1 attempt(s) MERGE_LEN5: MERGE-OUTER: succesfull in 1 attempt(s)
# Check that we honor TMPDIR
RUN: TMPDIR=DIR_DOES_NOT_EXIST not LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=TMPDIR
TMPDIR: MERGE-OUTER: failed to write to the control file: DIR_DOES_NOT_EXIST/libFuzzerTemp
# Check that we can report an error if file size exceeded
RUN: (ulimit -f 1; not LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=SIGXFSZ)
SIGXFSZ: ERROR: libFuzzer: file size exceeded
RUN: rm -rf %tmp/T1/* %tmp/T2/* RUN: rm -rf %tmp/T1/* %tmp/T2/*
RUN: not LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=EMPTY RUN: not LLVMFuzzer-FullCoverageSetTest -merge=1 %tmp/T1 %tmp/T2 2>&1 | FileCheck %s --check-prefix=EMPTY
EMPTY: MERGE-OUTER: zero succesfull attempts, exiting EMPTY: MERGE-OUTER: zero succesfull attempts, exiting