This is an archive of the discontinued LLVM Phabricator instance.

COFF: add test for /INCLUDE directives specified in bitcode
ClosedPublic

Authored by inglorion on Jan 24 2017, 1:24 PM.

Details

Summary

MSVC allows linker options to be specified in source code. One of these is the /INCLUDE directive, which specifies that a symbol must be added to the symbol table, even if it otherwise wouldn't be. Existing tests cover the case where the linker is given an object file with an /INCLUDE directive, but we also need to cover the case where /INCLUDE is specified in a bitcode file (as would happen when using LTO). This new test covers that case.

Diff Detail

Repository
rL LLVM

Event Timeline

inglorion created this revision.Jan 24 2017, 1:24 PM
inglorion retitled this revision from COFF: add test for /INCLUDE directives specified in sources to COFF: add test for /INCLUDE directives specified in bitcode.Jan 24 2017, 1:26 PM
ruiu accepted this revision.Jan 24 2017, 1:29 PM

LGTM

This revision is now accepted and ready to land.Jan 24 2017, 1:29 PM
This revision was automatically updated to reflect the committed changes.