[AST Printer] Print attributes on enum constants

[jordan_rose]

Summary

The AST printer was dropping attributes on enumerators (enum constants). Now it's not.

[aaron.ballman]

LGTM, though if you wanted to add one more test with a C++ attribute (deprecated would work in C++14 mode), that would not make me sad. Something like:

enum [[deprecated]] E {
  One [[deprecated]] 
};

[jordan_rose]

Good idea, will do.

[jordan_rose]

Interestingly, this case doesn't actually work yet; we unconditionally print enum attributes after the close-brace even though that's not valid for C++ attributes. Do you think I should change that as well, or just land this patch as is?

[aaron.ballman]

In D28924#651139, @jordan_rose wrote:

Interestingly, this case doesn't actually work yet; we unconditionally print enum attributes after the close-brace even though that's not valid for C++ attributes. Do you think I should change that as well, or just land this patch as is?

This is a pervasive issue with attributes, now that I put my thinking cap on. I think you're fine to land it as-is; we need a much larger fix to handle pretty printing attributes properly for all flavors.

[jordan_rose]

Landed as-is in rL292571.

lib/AST/DeclPrinter.cpp

if (D->isCompleteDefinition()) {
     Out << " {\n";
     VisitDeclContext(D);
     Indent() << "}";
   }
 }
 
 void DeclPrinter::VisitEnumConstantDecl(EnumConstantDecl *D) {
   Out << *D;
+  prettyPrintAttributes(D);
   if (Expr *Init = D->getInitExpr()) {
     Out << " = ";
     Init->printPretty(Out, nullptr, Policy, Indentation);
   }
 }
 
 void DeclPrinter::VisitFunctionDecl(FunctionDecl *D) {
   if (!D->getDescribedFunctionTemplate() &&

test/Sema/ast-print.c

void initializers() {
   // CHECK: int *x = ((void *)0), *y = ((void *)0);
   int *x = ((void *)0), *y = ((void *)0);
   struct Z{};
   struct {
     struct Z z;
   // CHECK: } z = {(struct Z){}};
   } z = {(struct Z){}};
 }
+
+// CHECK-LABEL: enum EnumWithAttributes {
+enum EnumWithAttributes {
+  // CHECK-NEXT: EnumWithAttributesFoo __attribute__((deprecated(""))),
+  EnumWithAttributesFoo __attribute__((deprecated)),
+  // CHECK-NEXT: EnumWithAttributesBar __attribute__((unavailable(""))) = 50
+  EnumWithAttributesBar __attribute__((unavailable)) = 50
+  // CHECK-NEXT: } __attribute__((deprecated("")))
+} __attribute__((deprecated));