Non-virtual subtarget features functions

[samparker]

Summary

Remove the virtual specifier from the getARM and getMIPSFeatures.

[echristo]

Can you resend this and add llvm-commits on the initial send out so mail will go to the list as well?

Thanks!

[echristo]

(Otherwise I think I'm fine with the patch, just need to do that.)

[samparker]

Hi Eric,

I seem to have accidentally committed this back in January along with a different patch! See D29283, sorry about this, I must of forgotten to clean my working directory.

cheers,
sam

[echristo]

No worries at all. Thanks!

include/llvm/Object/ELFObjectFile.h

 
   SubtargetFeatures getFeatures() const override;
 
-  SubtargetFeatures getMIPSFeatures() const override;
+  SubtargetFeatures getMIPSFeatures() const;
 
-  SubtargetFeatures getARMFeatures() const override;
+  SubtargetFeatures getARMFeatures() const;
 
   void setARMSubArch(Triple &TheTriple) const override;
 };

include/llvm/Object/ObjectFile.h

   virtual StringRef getFileFormatName() const = 0;
   virtual /* Triple::ArchType */ unsigned getArch() const = 0;
   virtual SubtargetFeatures getFeatures() const = 0;
-  virtual SubtargetFeatures getMIPSFeatures() const { return SubtargetFeatures(); }
-  virtual SubtargetFeatures getARMFeatures() const { return SubtargetFeatures(); }
   virtual void setARMSubArch(Triple &TheTriple) const { }
 
   /// Returns platform-specific object flags, if any.