[PATCH] Fix warning about parentheses in boolean expression.

[gonsolo]

Summary

Fix a warning from gcc.

[• dberlin]

I'm not sure why it's complaining since clang doesn't, but you want the parentheses around everything before the &&

[gonsolo]

Better?

[fhahn]

Sorry for the noise, I'm not sure what I did for Phabricator to think I updated the revision. But it looks like the review still shows the most recent revision.

[davide]

lib/Transforms/Scalar/NewGVN.cpp

1080–1088 ↗

(On Diff #84453)

This needs to be clang-formatt'ed

[gonsolo]

Clang-formatted. I think it was more readable before that.

[davide]

In D28731#646483, @gonsolo wrote:

Clang-formatted. I think it was more readable before that.

In D28731#646483, @gonsolo wrote:

Clang-formatted. I think it was more readable before that.

You formatted unrelated chunks. Revert that and LGTM. Do you need somebody to commit this on your behalf?

[gonsolo]

I thought clang-formatting a few unrelated changes is ok but anyways, here is the new patch.

Please commit, I can't.

[davide]

In D28731#646533, @gonsolo wrote:

I thought clang-formatting a few unrelated changes is ok but anyways, here is the new patch.

It's generally good practice not mixing functional changes and stylistic changes.

[davide]

In D28731#646533, @gonsolo wrote:

I thought clang-formatting a few unrelated changes is ok but anyways, here is the new patch.

Please commit, I can't.

Also, please update a patch with context next time.

llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp

void NewGVN::moveValueToNewCongruenceClass(Instruction *I,
 
   if (I == OldClass->NextLeader.first)
     OldClass->NextLeader = {nullptr, ~0U};
 
   // The new instruction and new class leader may either be siblings in the
   // dominator tree, or the new class leader should dominate the new member
   // instruction.  We simply check that the member instruction does not properly
   // dominate the new class leader.
-  assert(
-      !isa<Instruction>(NewClass->RepLeader) || !NewClass->RepLeader ||
+  assert((!isa<Instruction>(NewClass->RepLeader) || !NewClass->RepLeader ||
           I == NewClass->RepLeader ||
           !DT->properlyDominates(
               I->getParent(),
-          cast<Instruction>(NewClass->RepLeader)->getParent()) &&
-          "New class for instruction should not be dominated by instruction");
+              cast<Instruction>(NewClass->RepLeader)->getParent())) &&
 
   if (NewClass->RepLeader != I) {
     auto DFSNum = InstrDFS.lookup(I);
     if (DFSNum < NewClass->NextLeader.second)
       NewClass->NextLeader = {I, DFSNum};
   }
 
   OldClass->Members.erase(I);