This is an archive of the discontinued LLVM Phabricator instance.

[PATCH] Fix warning about parentheses in boolean expression.
ClosedPublic

Authored by gonsolo on Jan 14 2017, 7:15 AM.

Diff Detail

Event Timeline

gonsolo updated this revision to Diff 84450.Jan 14 2017, 7:15 AM
gonsolo retitled this revision from to [PATCH] Fix warning about parentheses in boolean expression. .
gonsolo updated this object.
gonsolo added a reviewer: dberlin.
gonsolo added a subscriber: llvm-commits.
dberlin edited edge metadata.Jan 14 2017, 7:30 AM

I'm not sure why it's complaining since clang doesn't, but you want the parentheses around everything before the &&

gonsolo updated this revision to Diff 84453.Jan 14 2017, 8:44 AM
gonsolo edited edge metadata.

Better?

fhahn updated this revision to Diff 84450.Jan 14 2017, 9:40 AM
fhahn added a subscriber: fhahn.
fhahn added a comment.Jan 14 2017, 9:52 AM

Sorry for the noise, I'm not sure what I did for Phabricator to think I updated the revision. But it looks like the review still shows the most recent revision.

davide requested changes to this revision.Jan 14 2017, 10:16 AM
davide added a reviewer: davide.
davide added a subscriber: davide.
davide added inline comments.
lib/Transforms/Scalar/NewGVN.cpp
1080–1088

This needs to be clang-formatt'ed

This revision now requires changes to proceed.Jan 14 2017, 10:16 AM
gonsolo updated this revision to Diff 84456.Jan 14 2017, 10:24 AM
gonsolo edited edge metadata.
gonsolo removed rL LLVM as the repository for this revision.

Clang-formatted. I think it was more readable before that.

davide accepted this revision.Jan 14 2017, 11:24 AM
davide edited edge metadata.

Clang-formatted. I think it was more readable before that.

Clang-formatted. I think it was more readable before that.

You formatted unrelated chunks. Revert that and LGTM. Do you need somebody to commit this on your behalf?

This revision is now accepted and ready to land.Jan 14 2017, 11:24 AM
gonsolo updated this revision to Diff 84461.Jan 14 2017, 12:48 PM
gonsolo edited edge metadata.

I thought clang-formatting a few unrelated changes is ok but anyways, here is the new patch.

Please commit, I can't.

I thought clang-formatting a few unrelated changes is ok but anyways, here is the new patch.

It's generally good practice not mixing functional changes and stylistic changes.

I thought clang-formatting a few unrelated changes is ok but anyways, here is the new patch.

Please commit, I can't.

Also, please update a patch with context next time.

This revision was automatically updated to reflect the committed changes.