[test-release.sh] Add Polly to the list of projects

[hans]

Should we leave it off by default? I don't think most testers have built with polly before. Maybe raise this on the release-testers list?

[grosser]

Hi,

this is a great change.

Regarding the default off flag, Even with this flag to on, Polly will not influence the default behavior of clang/LLVM/... So the only thing that is tested by default is that our unit tests work on all platforms and that the build system does not cause troubles.

Now, I still think that we should not force Polly on our release testers. So off sounds like the right default for this patch.

Obviously, I would very much appreciate them to test Polly, but as Hans suggested we should kindly ask this on the release testers mailing list.

Best,
Tobias

[pzheng]

[test-release.sh] Add Polly to the list of projects

[pzheng]

I agree that we should probably leave the default for Polly to be off since this is the first attempt to add it to the test release script and release testers may not be familiar with Polly. We can revisit turning it on by default in the future.

[grosser]

This looks good to me.

After this has been committed, we should probably ask the release builders if they would be OK to also run builds with -polly enabled.

[grosser]

The next LLVM release is coming up, we just verified that Polly can compile all of AOSP, and Polly has been shipping in debian and ubuntu since over a year. We should consider to flip the switch now. Pengxuan, would you like to propose such a patch?

[pzheng]

Here is the patch to enable Polly by default:
https://reviews.llvm.org/D34306

utils/release/test-release.sh

 do_asserts="no"
 do_compare="yes"
 do_rt="yes"
 do_libs="yes"
 do_libunwind="yes"
 do_test_suite="yes"
 do_openmp="yes"
 do_lldb="no"
+do_polly="no"
 BuildDir="`pwd`"
 ExtraConfigureFlags=""
 ExportBranch=""
 
 function usage() {
     echo "usage: `basename $0` -release X.Y.Z -rc NUM [OPTIONS]"
     echo ""
     echo " -release X.Y.Z       The release version to test."
function usage() {
     echo "                      For example -svn-path trunk or -svn-path branches/release_37"
     echo " -no-rt               Disable check-out & build Compiler-RT"
     echo " -no-libs             Disable check-out & build libcxx/libcxxabi/libunwind"
     echo " -no-libunwind        Disable check-out & build libunwind"
     echo " -no-test-suite       Disable check-out & build test-suite"
     echo " -no-openmp           Disable check-out & build libomp"
     echo " -lldb                Enable check-out & build lldb"
     echo " -no-lldb             Disable check-out & build lldb (default)"
+    echo " -polly               Enable check-out & build Polly"
+    echo " -no-polly            Disable check-out & build Polly (default)"
 }
 
 while [ $# -gt 0 ]; do
     case $1 in
         -release | --release )
             shift
             Release="$1"
             Release_no_dot="`echo $1 | sed -e 's,\.,,g'`"
case $1 in
             do_openmp="no"
             ;;
         -lldb )
             do_lldb="yes"
             ;;
         -no-lldb )
             do_lldb="no"
             ;;
+        -polly )
+            do_polly="yes"
+            ;;
+        -no-polly )
+            do_polly="no"
+            ;;
         -help | --help | -h | --h | -\? )
             usage
             exit 0
             ;;
         * )
             echo "unknown option: $1"
             usage
             exit 1
yes|export-only)
     ;;
 esac
 if [ $do_openmp = "yes" ]; then
   projects="$projects openmp"
 fi
 if [ $do_lldb = "yes" ]; then
   projects="$projects lldb"
 fi
+if [ $do_polly = "yes" ]; then
+  projects="$projects polly"
+fi
 
 # Go to the build directory (may be different from CWD)
 BuildDir=$BuildDir/$RC
 mkdir -p $BuildDir
 cd $BuildDir
 
 # Location of log files.
 LogDir=$BuildDir/logs
function export_sources() {
     for proj in $projects ; do
         case $proj in
         llvm)
             projsrc=$proj.src
             ;;
         cfe)
             projsrc=llvm.src/tools/clang
             ;;
-        lldb)
+        lldb|polly)
             projsrc=llvm.src/tools/$proj
             ;;
         clang-tools-extra)
             projsrc=llvm.src/tools/clang/tools/extra
             ;;
         compiler-rt|libcxx|libcxxabi|libunwind|openmp)
             projsrc=llvm.src/projects/$proj
             ;;